[Hw PFCWD feature] Skeleton hw pfcwd#4403
Open
abhishek-nexthop wants to merge 3 commits intosonic-net:masterfrom
Open
[Hw PFCWD feature] Skeleton hw pfcwd#4403abhishek-nexthop wants to merge 3 commits intosonic-net:masterfrom
abhishek-nexthop wants to merge 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek <abhishek@nexthop.ai>
… functions. Signed-off-by: Abhishek <abhishek@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhishek-nexthop
force-pushed
the
skeleton-hw-pfcwd
branch
from
28da074 to
dd3fc1c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhishek-nexthop
force-pushed
the
skeleton-hw-pfcwd
branch
from
dd3fc1c to
d1e15c4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhishek-nexthop
changed the title
abhishek-nexthop
force-pushed
the
skeleton-hw-pfcwd
branch
from
d1e15c4 to
4c5ce7a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhishek-nexthop
force-pushed
the
skeleton-hw-pfcwd
branch
from
4c5ce7a to
9d92949
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek <abhishek@nexthop.ai>
abhishek-nexthop
force-pushed
the
skeleton-hw-pfcwd
branch
from
9d92949 to
cfbfb45
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added hardware-based PFC watchdog support with SKU-specific enablement. Created PfcWdHwOrch skeleton class that inherits from PfcWdBaseOrch, refactored shared functionality into the base class, and implemented runtime SKU detection to automatically choose between hardware and software watchdog implementations.
Why I did it
Modern switch ASICs support hardware-based PFC deadlock detection/recovery which is more efficient than software-based approaches. Need infrastructure to:
• Enable hardware watchdog only on supported SKUs
• Share common code between software and hardware implementations
• Gracefully fall back to software watchdog on unsupported platforms
How I verified it
• Check logs: grep "PFC hardware watchdog" /var/log/syslog
• Supported SKU shows: "HWSKU 'nh-4010' supports PFC hardware watchdog"
• Unsupported SKU shows: "does not support PFC hardware watchdog"