[P4Orch] Add IPv6 src IP as new ternary key field for table ipv6_tunnel_termination_table#4238
Merged
StephenWangGoogle merged 1 commit intosonic-net:masterfrom Mar 9, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ksravani-hcl
force-pushed
the
p4orch_g3
branch
from
b5695ea to
9048f56
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
ksravani-hcl
force-pushed
the
p4orch_g3
branch
from
9048f56 to
a594d31
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yunang-c
reviewed
Mar 5, 2026
yunang-c
left a comment
yunang-c
left a comment
There was a problem hiding this comment.
The commit 06641a1 generally LGTM.
But there are too many inconsistent indentations in this commit (I pointed out a few, but it may have more). We probably didn't do a good job to make the coding style consistent when upstreaming the previous commits, but let's try to ensure they are for new PRs.
You can find the clangformat used by @mint570 to format previous PRs in #3080
There was a problem hiding this comment.
this seems to be committed accidentally?
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunang-c
approved these changes
Mar 6, 2026
yunang-c
left a comment
yunang-c
left a comment
There was a problem hiding this comment.
Thanks for the updated change, @ksravani-hcl ! It is much easier to review now.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ation_table Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenWangGoogle
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Verified with UT cases
Details if related