[action] [PR:3966] [portsorch] fix crash when number of PGs returned 0#4106
Merged
mssonicbld merged 1 commit intosonic-net:202511from Jan 5, 2026
Merged
Conversation
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Fix issue reported in sonic-net#3961. Regression happened after move to bulk implementation. The error handling of no PGs, queues was incorrect. Bulk array preparation and reading should use a consistent approach. For example, if a port is skipped in the input array, it should also be skipped when reading from the output array. **Why I did it** Fix issue reported in sonic-net#3961. **How I verified it** Implemented a UT to ensure no crash happens when number of PGs, queues or scheudler group is 0. **Details if related**
Collaborator
Author
|
Original PR: #3966 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix issue reported in #3961.
Regression happened after move to bulk implementation. The error handling of no PGs, queues was incorrect.
Bulk array preparation and reading should use a consistent approach. For example, if a port is skipped in the input array, it should also be skipped when reading from the output array.
Why I did it
Fix issue reported in #3961.
How I verified it
Implemented a UT to ensure no crash happens when number of PGs, queues or scheudler group is 0.
Details if related