[RouteOrch] fix performance regression in ResponsePublisher#4079
Closed
stepanblyschak wants to merge 3 commits intosonic-net:masterfrom
Closed
[RouteOrch] fix performance regression in ResponsePublisher#4079stepanblyschak wants to merge 3 commits intosonic-net:masterfrom
stepanblyschak wants to merge 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
fix-routeorch-resp
branch
from
5a6ac2f to
40a5c1c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@dgsudharsan to take over this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
setBufferedwasn't using Redis pipeline correctly.publishAPI avoiding RedisHGETwhich breaks Redis pipeline.Why I did it
Fix performance degradation observed in BGP suppress test.
How I verified it
config bgp startup alland profile.Without this change:
With this change:
Details if related