Respect Cargo.lock for dependencies version#4028
Merged
prsunny merged 3 commits intosonic-net:masterfrom Dec 3, 2025
Merged
Conversation
qiluo-msft
requested review from
Pterosaur and
Copilot
and removed request for
Copilot and
prsunny
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
We'd still somehow need to handle the locked version being significantly different from the swss-common version/hash being used in the pipeline (as build artifacts). |
saiarcot895
approved these changes
Dec 2, 2025
Pterosaur
approved these changes
Dec 2, 2025
prabhataravind
previously approved these changes
Dec 2, 2025
|
with locked, we lose the ability to automatically upgrade dependencies to pick up fixes. Are we going to manually upgrade? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Dec 3, 2025
Contributor
|
@qiluo-msft , How about using Cargo.lock in swss, dash-ha repo for UT. When UT passed, PR can be merged into swss repo. |
qiluo-msft
added a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Dec 9, 2025
…1124) This reverts commit 7682785. Following the proper fix sonic-swss (sonic-net/sonic-swss#4028). Now we could bring back the commit. What I did in the PR: Fix several potential crash issues: unwrap() function may crash in runtime. Drop should not crash. Clone should not crash, so remove it. Protect casting Duration
Collaborator
|
Cherry-pick PR to 202511: #4051 |
|
hi @qiluo-msft , I wonder if you could help pick this PR to 202412 as well? |
qiluo-msft
added a commit
to qiluo-msft/sonic-swss
that referenced
this pull request
Dec 9, 2025
Why I did it Currently cargo update will update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail. How I verified it Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api.
Contributor
Author
ack |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
mssonicbld
added a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Dec 10, 2025
…onic-net#1118) Following the proper fix sonic-swss (sonic-net/sonic-swss#4028). Now we could bring back the commit. What I did in the PR: Fix several potential crash issues: 1. unwrap() function may crash in runtime. 2. Drop should not crash. 3. Clone should not crash, so remove it. 4. Protect casting Duration
vmittal-msft
added a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Dec 11, 2025
…1136) Following the proper fix sonic-swss (sonic-net/sonic-swss#4028). Now we could bring back the commit. What I did in the PR: Fix several potential crash issues: 1. unwrap() function may crash in runtime. 2. Drop should not crash. 3. Clone should not crash, so remove it. 4. Protect casting Duration Co-authored-by: Vineet Mittal <46945843+vmittal-msft@users.noreply.github.com>
gpunathilell
pushed a commit
to gpunathilell/sonic-swss
that referenced
this pull request
Dec 12, 2025
Why I did it Currently cargo update will update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail. How I verified it Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api.
kalash-nexthop
pushed a commit
to kalash-nexthop/sonic-swss
that referenced
this pull request
Dec 16, 2025
Why I did it Currently cargo update will update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail. How I verified it Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api. Signed-off-by: Kalash Nainwal <kalash@nexthop.ai>
|
Cherry pick here: Azure/sonic-swss.msft#184 |
r12f
added
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
Pterosaur
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Jan 6, 2026
Why I did it Currently cargo update will update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail. How I verified it Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api.
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
Why I did it Currently cargo update will update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail. How I verified it Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Currently
cargo updatewill update dependencies in the Cargo.lock file to the latest version on the specified branch. The sonic-swss-common Rust code is possibly not aligned with libswsscommon package, which will make sonic-buildimage build fail.How I verified it
Verify local sonic-buildimage build passing, even there is sonic-swss-common changes on c-api.
Details if related