Skip to content

use IP cmd to setup vlan_filter as a backup method#401

Merged
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:vlan_filter
Nov 30, 2017
Merged

use IP cmd to setup vlan_filter as a backup method#401
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:vlan_filter

Conversation

@lguohan
Copy link
Contributor

@lguohan lguohan commented Nov 30, 2017

What I did
use IP cmd to setup vlan_filter as a backup method

Why I did it
echo will fail in virtual switch since /sys directory is read-only.
need to use ip command to setup the vlan_filtering which is not available in debian 8.
Once we move sonic to debian 9, we can use IP command by default

How I verified it
build virtual switch and verified.

Details if related
Will generate an PR to add test for virtual switch. The test will be in another PR since we need to build the new virtual switch docker first.

echo will fail in virtual switch since /sys directory is read-only.
need to use ip command to setup the vlan_filtering which is not available in debian 8.
Once we move sonic to debian 9, we can use IP command by default.
@lguohan
Copy link
Contributor Author

lguohan commented Nov 30, 2017

@JipanYanga to review

Copy link
Contributor

@jipanyang jipanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@lguohan lguohan merged commit 57a98ac into sonic-net:master Nov 30, 2017
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* Move stop notifications trhead after remove switch

* Remove stop notifications processing thread from pre shutdown
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
…net#401)

echo will fail in virtual switch since /sys directory is read-only.
need to use ip command to setup the vlan_filtering which is not available in debian 8.
Once we move sonic to debian 9, we can use IP command by default.
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants