Fix breakage for smartswitch usecase#3999
Closed
venkit-nexthop wants to merge 97 commits intosonic-net:masterfrom
Closed
Fix breakage for smartswitch usecase#3999venkit-nexthop wants to merge 97 commits intosonic-net:masterfrom
venkit-nexthop wants to merge 97 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
tagging @dgsudharsan as well. |
venkit-nexthop
force-pushed
the
master
branch
from
61896f1 to
6ef904d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Venkit Kasiviswanathan <[email protected]>
…ndatory. Signed-off-by: mint570 <[email protected]> Signed-off-by: Venkit Kasiviswanathan <[email protected]>
Signed-off-by: SRAVANI KANASANI <[email protected]> Signed-off-by: Venkit Kasiviswanathan <[email protected]>
What I did [LPO] Added support for serdes Tx/Rx polarity settings Why I did it To set the polarity for Tx and Rx serdes lanes as needed for LPO optics Signed-off-by: Venkit Kasiviswanathan <[email protected]>
- What I did Check if SAI_DASH_APPLIANCE_ATTR_LOCAL_REGION_ID is implemented before attempting to create the dash appliance object. - Why I did it This prevents error handling for SAI_STATUS_NOT_IMPLEMENTED by proactively checking attribute capability using sai_query_attribute_capability. - Changes: Add capability check before creating dash appliance object Only create appliance if attribute is supported and implemented How I verified it Run DASH FNIC test Signed-off-by: Oleksandr Ivantsiv <[email protected]> Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]> Signed-off-by: Venkit Kasiviswanathan <[email protected]>
Signed-off-by: Venkit Kasiviswanathan <[email protected]>
venkit-nexthop
force-pushed
the
master
branch
from
71b84ac to
e3a0114
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
I am going to abandon this PR and am going to create a new one from a fresh fork. This is because I hitting this DCO error which is very painful for me to fix (based on the suggested way). |
1 similar comment
Contributor
Author
|
I am going to abandon this PR and am going to create a new one from a fresh fork. This is because I hitting this DCO error which is very painful for me to fix (based on the suggested way). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Make fpmsyncd use the mgmt vrf to bind to zmq when configured.
Why I did it
Refer to sonic-net/sonic-buildimage#19638 The previous PR (#3979) inadvertantly caused the above issue.
This commit fixes that by connecting to zmq from fpmsyncd using the vrf as well (if one is configured)
How I verified it
By ensuring that when mgmt vrf is configured, FRR routes are programmed correctly via orchagent.
I also ran test_gnmi_zmq.py with the following diff and it ran successfully.
Details if related