Support checking capabilities of the mirror#3934
Merged
prsunny merged 4 commits intosonic-net:masterfrom Nov 21, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
the failure is not relevant to the change. retrying. |
Collaborator
Author
|
The vs test failure should be fixed by #3931 |
stephenxs
force-pushed
the
mirror_capability_check
branch
from
f4d25d4 to
ef57314
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
mirror_capability_check
branch
from
ef57314 to
4eee38e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
mirror_capability_check
branch
from
d2cd29c to
cd56ff7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Oct 23, 2025
keboliu
approved these changes
Oct 23, 2025
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
mirror_capability_check
branch
from
cd56ff7 to
5c86377
Compare
Collaborator
|
/azp run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
mirror_capability_check
branch
from
253b309 to
21a7e15
Compare
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@stephenxs can you please rebase ? we need this for updating sonic-utilities submodule in master. |
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
mirror_capability_check
branch
from
21a7e15 to
d20faae
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
@vmittal-msft @prsunny @bingwang-ms all test passed. could you please merge it? thanks |
kalash-nexthop
pushed a commit
to kalash-nexthop/sonic-swss
that referenced
this pull request
Dec 16, 2025
What I did Support checking the capabilities of ingress/egress mirror before setting it to SAI. Switch orchagent fetches the mirror capabilities from SAI during initialization and exposes to field PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY. Mirror orchagent check whether the direction is supported before calling the corresponding SAI API. Why I did it This is to avoid SAI returning error on the platforms that the mirror is not supported on a direction. It will collect SAI SDK dump on receiving a SAI error message, which is unnecessary. Signed-off-by: Kalash Nainwal <[email protected]>
Pterosaur
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Jan 6, 2026
What I did Support checking the capabilities of ingress/egress mirror before setting it to SAI. Switch orchagent fetches the mirror capabilities from SAI during initialization and exposes to field PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY. Mirror orchagent check whether the direction is supported before calling the corresponding SAI API. Why I did it This is to avoid SAI returning error on the platforms that the mirror is not supported on a direction. It will collect SAI SDK dump on receiving a SAI error message, which is unnecessary.
Collaborator
|
Cherry-pick PR to 202511: #4137 |
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
What I did Support checking the capabilities of ingress/egress mirror before setting it to SAI. Switch orchagent fetches the mirror capabilities from SAI during initialization and exposes to field PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY. Mirror orchagent check whether the direction is supported before calling the corresponding SAI API. Why I did it This is to avoid SAI returning error on the platforms that the mirror is not supported on a direction. It will collect SAI SDK dump on receiving a SAI error message, which is unnecessary. Signed-off-by: Lawrence Lee <[email protected]>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Support checking the capabilities of ingress/egress mirror before setting it to SAI. Switch orchagent fetches the mirror capabilities from SAI during initialization and exposes to field PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY. Mirror orchagent check whether the direction is supported before calling the corresponding SAI API. Why I did it This is to avoid SAI returning error on the platforms that the mirror is not supported on a direction. It will collect SAI SDK dump on receiving a SAI error message, which is unnecessary. Signed-off-by: Baorong Liu <[email protected]>
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Support checking the capabilities of ingress/egress mirror before setting it to SAI.
PORT_INGRESS_MIRROR_CAPABLEandPORT_EGRESS_MIRROR_CAPABLEinSTATE_DBtableSWITCH_CAPABILITY.Why I did it
This is to avoid SAI returning error on the platforms that the mirror is not supported on a direction.
It will collect SAI SDK dump on receiving a SAI error message, which is unnecessary.
How I verified it
Mock test + manual test
Details if related