Skip to content

[action] [PR:3798] Enhance return code handling for queryEnumCapabilitiesSai #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mssonicbld merged 1 commit into from
Aug 6, 2025
Merged

[action] [PR:3798] Enhance return code handling for queryEnumCapabilitiesSai #3810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions orchagent/switch/trimming/capabilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,15 @@ void SwitchTrimmingCapabilities::queryTrimDscpModeEnumCapabilities()
auto status = queryEnumCapabilitiesSai(
mList, SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE
);
if (status != SAI_STATUS_SUCCESS)
if (status == SAI_STATUS_NOT_SUPPORTED)
{
SWSS_LOG_NOTICE(
"Attribute not supported(%s) to query enum value capabilities",
toStr(SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE).c_str()
);
return;
}
else if (status != SAI_STATUS_SUCCESS)
{
SWSS_LOG_ERROR(
"Failed to get attribute(%s) enum value capabilities",
Expand Down Expand Up @@ -369,7 +377,15 @@ void SwitchTrimmingCapabilities::queryTrimDscpModeAttrCapabilities()
auto status = queryAttrCapabilitiesSai(
attrCap, SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE
);
if (status != SAI_STATUS_SUCCESS)
if (status == SAI_STATUS_NOT_SUPPORTED)
{
SWSS_LOG_NOTICE(
"Attribute not supported(%s) to query attr vapabilities",
toStr(SAI_OBJECT_TYPE_SWITCH, SAI_SWITCH_ATTR_PACKET_TRIM_DSCP_RESOLUTION_MODE).c_str()
);
return;
}
else if (status != SAI_STATUS_SUCCESS)
{
SWSS_LOG_ERROR(
"Failed to get attribute(%s) capabilities",
Expand Down
Loading