[Mux] Clear bulkers when rolling back mux switchover#3788
Merged
prsunny merged 4 commits intosonic-net:masterfrom Jul 25, 2025
Merged
[Mux] Clear bulkers when rolling back mux switchover#3788prsunny merged 4 commits intosonic-net:masterfrom
prsunny merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
approved these changes
Jul 25, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to 202505: #3855 |
|
add 202505 label to see whether it fix the unit test failure in |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss.msft#152 |
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did When a switchover failure is detected in MuxOrch, clear relevant bulkers to provide a clean slate for the rollback process. Why I did it In certain failure scenarios, if an exception is thrown inside the bulker, it's possible that the bulker is not cleared and still contains data in creating_entries or removing_entries. When the rollback process begins, these entries will be programmed to the SAI a second time, which is a) incorrect b) could potentially trigger the same exception second time. How I verified it Run the MuxRollbackTest.StandbyToActiveExceptionRollbackToStandby test
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
What I did When a switchover failure is detected in MuxOrch, clear relevant bulkers to provide a clean slate for the rollback process. Why I did it In certain failure scenarios, if an exception is thrown inside the bulker, it's possible that the bulker is not cleared and still contains data in creating_entries or removing_entries. When the rollback process begins, these entries will be programmed to the SAI a second time, which is a) incorrect b) could potentially trigger the same exception second time. How I verified it Run the MuxRollbackTest.StandbyToActiveExceptionRollbackToStandby test
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
What I did When a switchover failure is detected in MuxOrch, clear relevant bulkers to provide a clean slate for the rollback process. Why I did it In certain failure scenarios, if an exception is thrown inside the bulker, it's possible that the bulker is not cleared and still contains data in creating_entries or removing_entries. When the rollback process begins, these entries will be programmed to the SAI a second time, which is a) incorrect b) could potentially trigger the same exception second time. How I verified it Run the MuxRollbackTest.StandbyToActiveExceptionRollbackToStandby test Signed-off-by: Lawrence Lee <[email protected]>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did When a switchover failure is detected in MuxOrch, clear relevant bulkers to provide a clean slate for the rollback process. Why I did it In certain failure scenarios, if an exception is thrown inside the bulker, it's possible that the bulker is not cleared and still contains data in creating_entries or removing_entries. When the rollback process begins, these entries will be programmed to the SAI a second time, which is a) incorrect b) could potentially trigger the same exception second time. How I verified it Run the MuxRollbackTest.StandbyToActiveExceptionRollbackToStandby test Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When a switchover failure is detected in MuxOrch, clear relevant bulkers to provide a clean slate for the rollback process.
Why I did it
In certain failure scenarios, if an exception is thrown inside the bulker, it's possible that the bulker is not cleared and still contains data in
creating_entriesorremoving_entries. When the rollback process begins, these entries will be programmed to the SAI a second time, which is a) incorrect b) could potentially trigger the same exception second time.How I verified it
Run the
MuxRollbackTest.StandbyToActiveExceptionRollbackToStandbytestDetails if related