[teamsyncd] remove m_stateLagTablePreserved by stepanblyschak · Pull Request #3782 · sonic-net/sonic-swss

stepanblyschak · 2025-07-23T17:31:58Z

Once LAG is created in the kernel set its state to STATE_DB immediately. STATE_DB flag triggers kernel LAG IP configuration, which does not need to be delayed.

Only LAG experience this behaviour, any other type of interface gets kernel IP configuration as soon as netdev is created.

What I did

Remove m_stateLagTablePreserved.

Why I did it

To not delay kernel LAG IP configuration.

Before:

2025 Jul 22 11:49:57.368571 mtvr-bison-133 NOTICE teamd#teamsyncd: :- checkWarmStart: teamsyncd doing warm start, restore count 1
2025 Jul 22 11:49:57.369866 mtvr-bison-133 INFO teamd#teamsyncd: :- onMsg:  nlmsg type:16 key:PortChannel0001 admin:1 oper:1 ifindex:4 type:team
2025 Jul 22 11:51:07.531605 mtvr-bison-133 DEBUG swss#intfmgrd: :- doIntfAddrTask: Interface is not ready, skipping PortChannel0001
2025 Jul 22 11:51:08.685359 mtvr-bison-133 NOTICE teamd#teamsyncd: :- applyState: Applying state
2025 Jul 22 11:51:10.611619 mtvr-bison-133 DEBUG swss#intfmgrd: :- exec: /sbin/ip address "add" "30.0.0.1/24" broadcast "30.0.0.255" dev "PortChannel0001" :  : Exited with rc=0

After:

2025 Jul 23 10:03:32.445081 mtvr-bison-133 NOTICE teamd#teamsyncd: :- checkWarmStart: teamsyncd doing warm start, restore count 1
2025 Jul 23 10:03:32.445879 mtvr-bison-133 INFO teamd#teamsyncd: :- onMsg:  nlmsg type:16 key:PortChannel0001 admin:1 oper:1 ifindex:4 type:team
2025 Jul 23 10:03:37.237107 mtvr-bison-133 DEBUG swss#intfmgrd: :- exec: /sbin/ip address "add" "30.0.0.1/24" broadcast "30.0.0.255" dev "PortChannel0001" :  : Exited with rc=0
2025 Jul 23 10:04:44.369749 mtvr-bison-133 NOTICE teamd#teamsyncd: :- applyState: Applying state

How I verified it

Ran following tests on Mellanox-SN4600C-C64 (master.0-e7331e3cb_Internal):

warm-reboot
warm-reboot-sad
warm-reboot-multi-sad-lag
warm-reboot-sad-lag-member
fast-reboot

Merge after - sonic-net/sonic-buildimage#24174

Details if related

Once LAG is created in the kernel set its state to STATE_DB immediately. STATE_DB flag triggers kernel LAG IP configuration, which does not need to be delayed. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

mssonicbld · 2025-07-23T17:32:06Z

/azp run

azure-pipelines · 2025-07-23T17:32:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-23T17:33:05Z

/azp run

azure-pipelines · 2025-07-23T17:33:15Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2025-07-23T17:44:27Z

@stepanblyschak , can you point to the PR that added this feature. IIRC, this was done for some WB corner cases and seems to be an impactful change. @vaibhavhd for viz

vaibhavhd · 2025-07-23T17:50:05Z

@stepanblyschak is the lack of this change the reason that portchannels are coming as OPER DOWN after warm-reboot to 202505?

We are trying to triage that issue, and we have reasons to suspect that the regression started after this PR #3563

Issue - sonic-net/sonic-buildimage#23347

stepanblyschak · 2025-07-23T18:02:21Z

@prsunny Since day 1 - #725

What is that corner case?

I ran all relevant tests I know:

warm-reboot
warm-reboot-sad
warm-reboot-multi-sad-lag
warm-reboot-sad-lag-member
fast-reboot

Sad path LAG cases should cover teamsyncd reconciliation flow.
If you know tests cases I missed please let me know I will run.

stepanblyschak · 2025-07-23T18:06:27Z

@stepanblyschak is the lack of this change the reason that portchannels are coming as OPER DOWN after warm-reboot to 202505?

We are trying to triage that issue, and we have reasons to suspect that the regression started after this PR #3563

Issue - sonic-net/sonic-buildimage#23347

@vaibhavhd no it's different, I see what's the issue, working on it.

stepanblyschak · 2025-07-24T07:36:27Z

/azpw run

mssonicbld · 2025-07-24T07:36:29Z

/AzurePipelines run

azure-pipelines · 2025-07-24T07:36:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-25T10:18:39Z

/azp run

azure-pipelines · 2025-07-25T10:18:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-25T18:48:52Z

/azp run

azure-pipelines · 2025-07-25T18:49:01Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-01T07:41:47Z

/azp run

azure-pipelines · 2025-08-01T07:41:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-09T11:57:32Z

/azp run

azure-pipelines · 2025-08-09T11:57:42Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2025-08-12T12:51:47Z

During continuous testing of warm-reboot it was found that this delay is intended to postpone establishment of BGP sessions with upstream devices. Otherwise, if we have downstream BGP sessions which are not yet established and the device sends incomplete routing table and then sends EOIU marker to upstream device, causing upstream device to delete routes. Ideally, could be solved by postponing EOIU from FRR to not delay kernel config.

mssonicbld · 2025-08-13T08:11:37Z

/azp run

azure-pipelines · 2025-08-13T08:11:47Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-09-04T06:41:47Z

/azp run

azure-pipelines · 2025-09-04T06:41:58Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2025-09-04T06:42:10Z

PR in draft due to FRR issue found causing the above

mssonicbld · 2025-10-01T12:26:41Z

/azp run

azure-pipelines · 2025-10-01T12:26:54Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 · 2025-10-29T15:13:17Z

During continuous testing of warm-reboot it was found that this delay is intended to postpone establishment of BGP sessions with upstream devices. Otherwise, if we have downstream BGP sessions which are not yet established and the device sends incomplete routing table and then sends EOIU marker to upstream device, causing upstream device to delete routes. Ideally, could be solved by postponing EOIU from FRR to not delay kernel config.

Wouldn't this mean that if we remove this delay, and the upstream LAGs have an IP address assigned first, and BGP gets established first with upstream devices, then that'll result in a deletion of many routes?

stepanblyschak · 2025-10-30T20:40:30Z

@saiarcot895 Issue described in the comment you refer to is solved by sonic-net/sonic-buildimage#24174.
Once that PR is in, this PR will be set Ready for review

liat-grozovik · 2025-11-09T12:48:44Z

@yxieca please help to assign someone to review the suggested improvements in fastboot. this is req for SKUs which have more and more ports but will definitely help with existing SKUs as well.
The change is expected to be part of 202511 thus need your review with prio.

yxieca · 2025-11-09T18:41:00Z

@stepanblyschak , @liat-grozovik , Both Vaibhav and Saikrishna have already engaged in reviewing. However, this PR is still in DRAFT mode.

What can make it ready for review?

stepanblyschak · 2025-11-10T08:35:32Z

@yxieca This PR depends on a merge of a bug fix in FRR sonic-net/sonic-buildimage#24174

mssonicbld · 2025-12-03T16:24:42Z

/azp run

azure-pipelines · 2025-12-03T16:24:54Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak added 2 commits July 22, 2025 13:07

[teamsyncd] remove m_stateLagTablePreserved

6156bfe

Once LAG is created in the kernel set its state to STATE_DB immediately. STATE_DB flag triggers kernel LAG IP configuration, which does not need to be delayed. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Add UT for teamsyncd

9ca3d1b

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak requested review from judyjoseph and prsunny as code owners July 23, 2025 17:31

stepanblyschak changed the title ~~Lag state immediate set~~ [teamsyncd] remove m_stateLagTablePreserved Jul 23, 2025

stepanblyschak added the Request for 202505 Branch label Jul 23, 2025

Merge branch 'master' into lag-state-immediate-set

461579a

stepanblyschak mentioned this pull request Jul 23, 2025

[fast-reboot] Remove teamsyncd timer override by fast-boot sonic-net/sonic-utilities#3996

Closed

Merge branch 'master' into lag-state-immediate-set

d81c4a0

Merge branch 'master' into lag-state-immediate-set

f9d256a

Merge branch 'master' into lag-state-immediate-set

0c4ad5a

Merge branch 'master' into lag-state-immediate-set

8d4835e

prsunny requested a review from saiarcot895 August 11, 2025 21:49

stepanblyschak closed this Aug 12, 2025

stepanblyschak reopened this Aug 13, 2025

stepanblyschak marked this pull request as draft August 13, 2025 08:11

Merge branch 'master' into lag-state-immediate-set

c428d8e

Merge branch 'master' into lag-state-immediate-set

4611ccb

stepanblyschak mentioned this pull request Oct 30, 2025

[FRR] send EOR during GR only when fib install complete sonic-net/sonic-buildimage#24174

Closed

9 tasks

Merge branch 'master' into lag-state-immediate-set

39f858b

YairRaviv mentioned this pull request Jan 29, 2026

[teamsyncd] remove m_stateLagTablePreserved #4170

Open

stepanblyschak closed this Jan 29, 2026

Conversation

stepanblyschak commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Jul 23, 2025

Uh oh!

azure-pipelines bot commented Jul 23, 2025

Uh oh!

mssonicbld commented Jul 23, 2025

Uh oh!

azure-pipelines bot commented Jul 23, 2025

Uh oh!

prsunny commented Jul 23, 2025

Uh oh!

vaibhavhd commented Jul 23, 2025

Uh oh!

stepanblyschak commented Jul 23, 2025

Uh oh!

stepanblyschak commented Jul 23, 2025

Uh oh!

stepanblyschak commented Jul 24, 2025

Uh oh!

mssonicbld commented Jul 24, 2025

Uh oh!

azure-pipelines bot commented Jul 24, 2025

Uh oh!

mssonicbld commented Jul 25, 2025

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

mssonicbld commented Jul 25, 2025

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

mssonicbld commented Aug 1, 2025

Uh oh!

azure-pipelines bot commented Aug 1, 2025

Uh oh!

mssonicbld commented Aug 9, 2025

Uh oh!

azure-pipelines bot commented Aug 9, 2025

Uh oh!

stepanblyschak commented Aug 12, 2025

Uh oh!

mssonicbld commented Aug 13, 2025

Uh oh!

azure-pipelines bot commented Aug 13, 2025

Uh oh!

mssonicbld commented Sep 4, 2025

Uh oh!

azure-pipelines bot commented Sep 4, 2025

Uh oh!

stepanblyschak commented Sep 4, 2025

Uh oh!

mssonicbld commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

saiarcot895 commented Oct 29, 2025

Uh oh!

stepanblyschak commented Oct 30, 2025

Uh oh!

liat-grozovik commented Nov 9, 2025

Uh oh!

yxieca commented Nov 9, 2025

Uh oh!

stepanblyschak commented Nov 10, 2025

Uh oh!

mssonicbld commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stepanblyschak commented Jul 23, 2025 •

edited

Loading