[trim]: Add Packet Trimming Drop Counters to OA#3777
Merged
dgsudharsan merged 2 commits intosonic-net:masterfrom Aug 18, 2025
Merged
[trim]: Add Packet Trimming Drop Counters to OA#3777dgsudharsan merged 2 commits intosonic-net:masterfrom
dgsudharsan merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
added
Request for 202505 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
nazariig
requested review from
dgsudharsan,
keboliu,
kperumalbfn,
liat-grozovik,
moshemos,
r12f and
volodymyrsamotiy
nazariig
force-pushed
the
master-trim-counter
branch
from
f5f5128 to
ae2e41f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
nazariig
force-pushed
the
master-trim-counter
branch
from
ae2e41f to
eaf3f9a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-trim-counter
branch
from
eaf3f9a to
9027799
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
volodymyrsamotiy
approved these changes
Jul 28, 2025
kperumalbfn
reviewed
Aug 1, 2025
nazariig
force-pushed
the
master-trim-counter
branch
from
9027799 to
9549228
Compare
nazariig
force-pushed
the
master-trim-counter
branch
from
94742e7 to
09f8827
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@kperumalbfn / @r12f all checks are passed. Please help to merge |
kperumalbfn
approved these changes
Aug 18, 2025
dgsudharsan
approved these changes
Aug 18, 2025
|
hi @nazariig , do you mind to help pick this change to 202412? |
Contributor
|
@r12f 202412 PR - Azure/sonic-swss.msft#130 please merge |
r12f
added
Included in msft-202412 Branch
Approved for msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
| SAI_QUEUE_STAT_DROPPED_PACKETS, | ||
| SAI_QUEUE_STAT_DROPPED_BYTES, | ||
| SAI_QUEUE_STAT_TRIM_PACKETS | ||
| SAI_QUEUE_STAT_TRIM_PACKETS, |
Contributor
There was a problem hiding this comment.
@nazariig TRIM specific stats are introducing more new SAI errors on non TH5 platforms, do you have plan to address this? @lolyu @aaronpayment @pandurangan-arista FYI.
2025 Aug 19 06:08:38.448632 gd231 ERR syncd#syncd: [none] SAI_API_SWITCH:_brcm_sai_xgs_pkt_trim_get_mapped_counter:102 Packet trim feature is not supported
2025 Aug 19 06:08:38.448632 gd231 ERR syncd#syncd: [none] SAI_API_QUEUE:_brcm_sai_xgs_queue_pkt_trim_get_clear_ctr:164 Get Trim mapped counter failed with error -2.
2025 Aug 19 06:08:38.448632 gd231 ERR syncd#syncd: [none] SAI_API_QUEUE:_brcm_sai_cosq_stat_get:1970 Get Trim stats packets failed with error -2.
Collaborator
Author
There was a problem hiding this comment.
@dhanasekar-arista since feature is not supported, please make sure SAI returns the relevant stats capabilities. Then counter polling won't take place. The capabilities check is already part of the flex counter infra
Collaborator
|
@nazariig would you please create a backport PR for 202505 as there is a conflict? |
|
Remove 202505 request label since packet trimming feature won't be included into 202505 branch. |
a114j0y
pushed a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 29, 2025
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
divyagayathri-hcl
pushed a commit
to divyagayathri-hcl/sonic-swss
that referenced
this pull request
Aug 29, 2025
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
arfeigin
pushed a commit
to arfeigin/sonic-swss
that referenced
this pull request
Oct 9, 2025
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
arfeigin
pushed a commit
to arfeigin/sonic-swss
that referenced
this pull request
Oct 9, 2025
…)" This reverts commit 6b76077.
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Oct 23, 2025
### Summary: Add packet trimming counter testcase phase1 ### Related PR - Add packet trimming drop counter test plan sonic-net/sonic-mgmt#19824 - Packet Trimming: Drop Counters HLD sonic-net/SONiC#2033 - [trim]: Add Packet Trimming Drop Counters YANG model sonic-net/sonic-buildimage#23422 - [trim]: Add Packet Trimming Drop Counters DB schema sonic-net/sonic-swss-common#1055 - [trim]: Add Packet Trimming Drop Counters to VS lib sonic-net/sonic-sairedis#1630 - [trim]: Add Packet Trimming Drop Counters to OA sonic-net/sonic-swss#3777 - [trim]: Add Packet Trimming Drop Counters CLI sonic-net/sonic-utilities#3993 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
11 tasks
mssonicbld
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Oct 23, 2025
### Summary: Add packet trimming counter testcase phase1 ### Related PR - Add packet trimming drop counter test plan sonic-net/sonic-mgmt#19824 - Packet Trimming: Drop Counters HLD sonic-net/SONiC#2033 - [trim]: Add Packet Trimming Drop Counters YANG model sonic-net/sonic-buildimage#23422 - [trim]: Add Packet Trimming Drop Counters DB schema sonic-net/sonic-swss-common#1055 - [trim]: Add Packet Trimming Drop Counters to VS lib sonic-net/sonic-sairedis#1630 - [trim]: Add Packet Trimming Drop Counters to OA sonic-net/sonic-swss#3777 - [trim]: Add Packet Trimming Drop Counters CLI sonic-net/sonic-utilities#3993 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
* [trim]: Add Packet Trimming Drop Counters to OA Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [trim]: Handle review comments Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
DEPENDS:
HLD: sonic-net/SONiC#2033
What I did
Why I did it
How I verified it
Details if related
A picture of a cute animal (not mandatory but encouraged)