[sonic-swss]: Add PFC Broadcom recommeded MMU Settings#377
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 10, 2017
Merged
[sonic-swss]: Add PFC Broadcom recommeded MMU Settings#377yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
This commit adds new code and JSON file to support PFC and broadcom recommended MMU settings for PFC feature. The JSON has the Broadcom recommended settings. JSON file dynamic_th values are exponent values for ALPHA setting taken from SAI code. Verified by running the JSON configuration file and checking the hardware registers and tables. The setting in the hardware was reflecting the Broadcom recommended values. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
Contributor
Author
|
@yxieca Can you please review |
yxieca
approved these changes
Nov 10, 2017
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
import ipaddr package and check if the ip address is ipv4 or ipv6 and set the corresponding rule properties Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Aug 24, 2023
What I did Admin-disable port before applying media-based NPU serdes attributes from media_settings.json. Why I did it This fix is needed along with xcvrd changes #377. Maintain deterministic behavior of interface bring-up, by toggling host_tx_ready flag, which will trigger CMIS reinit for the module once NPU serdes params have been applied. How I verified it Validated media_settings being notified and applied on Cisco 8111 with subject changes combined with diffs from #360, #377 and #15453. Will update final results once #377 is frozen. Details if related Proposal for xcvrd changes: #356 Signed-off-by: Aman Singhal <amans@cisco.com>
tshalvi
pushed a commit
to tshalvi/sonic-swss
that referenced
this pull request
Sep 18, 2023
…c-net#2831) What I did Admin-disable port before applying media-based NPU serdes attributes from media_settings.json. Why I did it This fix is needed along with xcvrd changes sonic-net#377. Maintain deterministic behavior of interface bring-up, by toggling host_tx_ready flag, which will trigger CMIS reinit for the module once NPU serdes params have been applied. How I verified it Validated media_settings being notified and applied on Cisco 8111 with subject changes combined with diffs from sonic-net#360, sonic-net#377 and #15453. Will update final results once sonic-net#377 is frozen. Details if related Proposal for xcvrd changes: sonic-net#356 Signed-off-by: Aman Singhal <amans@cisco.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This commit adds new code and JSON file to support PFC and broadcom recommended MMU settings for PFC feature. The JSON has the Broadcom recommended settings. JSON file dynamic_th values are exponent values for ALPHA setting taken from SAI code. Verified by running the JSON configuration file and checking the hardware registers and tables. The setting in the hardware was reflecting the Broadcom recommended values. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…c-net#2831) What I did Admin-disable port before applying media-based NPU serdes attributes from media_settings.json. Why I did it This fix is needed along with xcvrd changes sonic-net#377. Maintain deterministic behavior of interface bring-up, by toggling host_tx_ready flag, which will trigger CMIS reinit for the module once NPU serdes params have been applied. How I verified it Validated media_settings being notified and applied on Cisco 8111 with subject changes combined with diffs from sonic-net#360, sonic-net#377 and #15453. Will update final results once sonic-net#377 is frozen. Details if related Proposal for xcvrd changes: sonic-net#356 Signed-off-by: Aman Singhal <amans@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds new code and JSON file to support PFC and broadcom
recommended MMU settings for PFC feature. The JSON has the Broadcom
recommended settings. JSON file dynamic_th values are exponent values
for ALPHA setting taken from SAI code.
Verified by running the JSON configuration file and checking the
hardware registers and tables. The setting in the hardware was reflecting
the Broadcom recommended values.
Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com