[orchagent] Add PFC shared headroom support#368
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 7, 2017
Merged
Conversation
Contributor
Author
|
@yxieca, please review the changes |
vharish02
force-pushed
the
shared-headroom
branch
from
cf64417 to
66b98c5
Compare
yxieca
requested changes
Nov 3, 2017
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Harish,
I didn't realized you've created this PR when I created PR 369. I will close mine.
But please take a look at my change, include the definition of buffer_pool_xoff_field_name in your change set.
The reason for defining a new string is to make sure that buffer pool and buffer profile could independently change field name.
Thanks,
Ying
Contributor
Author
|
Hi Ying, I will make the change and resend it. Thanks, |
This commit adds new code to support PFC shared headroom pool size (Ingress) for lossless traffic feature. This is one of the requirement for PFC support on SONiC. Included the defintion of buffer_pool_xoff_field_name Verified by using a JSON configuration file to push the XOFF parameter to program in Hardware. XOFF parameter in JSON file translates to SAI_BUFFER_POOL_ATTR_XOFF_SIZE which gets programmed in register THDI_HDRM_BUFFER_CELL_LIMIT_HP. The register was programmed with correct values. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
vharish02
force-pushed
the
shared-headroom
branch
from
66b98c5 to
c3cf8b6
Compare
yxieca
approved these changes
Nov 7, 2017
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
ecnconfig check against invalid argument value (sonic-net#343)
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This commit adds new code to support PFC shared headroom pool size (Ingress) for lossless traffic feature. This is one of the requirement for PFC support on SONiC. Included the defintion of buffer_pool_xoff_field_name Verified by using a JSON configuration file to push the XOFF parameter to program in Hardware. XOFF parameter in JSON file translates to SAI_BUFFER_POOL_ATTR_XOFF_SIZE which gets programmed in register THDI_HDRM_BUFFER_CELL_LIMIT_HP. The register was programmed with correct values. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
* Fix swss::exec return value * Enum return values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds new code to support PFC shared headroom pool size
(Ingress) for lossless traffic feature. This is one of the requirement
for PFC support on SONiC.
Verified by using a JSON configuration file to push the XOFF parameter
to program in Hardware. XOFF parameter in JSON file translates to
SAI_BUFFER_POOL_ATTR_XOFF_SIZE which gets programmed in register
THDI_HDRM_BUFFER_CELL_LIMIT_HP. The register was programmed with correct
values.
Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com