Improve orchagent to enable Dash ZMQ by feature flag.#3619
Merged
prsunny merged 28 commits intosonic-net:masterfrom Jun 18, 2025
Merged
Improve orchagent to enable Dash ZMQ by feature flag.#3619prsunny merged 28 commits intosonic-net:masterfrom
prsunny merged 28 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
force-pushed
the
dev/liuh/improve_zmq_parameter
branch
from
828b23b to
10fa204
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
force-pushed
the
dev/liuh/improve_zmq_parameter
branch
from
8a20722 to
c87ff47
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
liuh-80
changed the title
Collaborator
|
/azp run |
prabhataravind
requested changes
Jun 13, 2025
Contributor
prabhataravind
left a comment
prabhataravind
left a comment
There was a problem hiding this comment.
Added a comment about the feature naming and logs to avoid confusion.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Fixed |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
ok to merge @prsunny and @prabhataravind ? |
divyagayathri-hcl
pushed a commit
to divyagayathri-hcl/sonic-swss
that referenced
this pull request
Jun 22, 2025
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451
divyagayathri-hcl
pushed a commit
to divyagayathri-hcl/sonic-swss
that referenced
this pull request
Jun 23, 2025
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451
9 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 17, 2025
Enable ZMQ on orchagent route table. Why I did it To enhance route performance, sonic-swss introduces a new feature enabling ZMQ communication between fpmsyncd and orchagent. With this change, the orchagent.sh script must be updated to always pass the ZMQ address parameter. Additionally, the feature flag changed during code review of sonic-net/sonic-swss#3619, so yang model and config also need update in this PR. Work item tracking Microsoft ADO (number only): 32582830 How I did it Update orchagent.sh and yang module. How to verify it Pass all test case Manually verified with latest image.
liuh-80
added a commit
to liuh-80/sonic-swss
that referenced
this pull request
Aug 31, 2025
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451 Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
Improve orchagent to enable Dash ZMQ by feature flag. Why I did it On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough. However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659 Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough. For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag. And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag. ZMQ feature flag add by following PR: sonic-net/sonic-buildimage#22451 Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve orchagent to enable Dash ZMQ by feature flag.
Why I did it
On current image, orchagent only enable ZMQ on Dash tables, so use -q option to control the ZMQ feature is enough.
However, we plan to improve route performance by enable ZMQ between fpmsyncd and orchagent. sonic-net/SONiC#1659
Then there will be 2 features on orchagent share same ZMQ address, so using -q to control the Dash ZMQ feature is not enough.
For Dash, we plan to migrate to enable/disable with the 'orch_dash_zmq_enabled' feature flag. There will be another PR in orchagent to make Dash enable/disable ZMQ with this flag.
And for improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag.
ZMQ feature flag add by following PR:
sonic-net/sonic-buildimage#22451
How I did it
Check feature flag when initialize orchagent
Work item tracking
How to verify it
Pass all test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Improve orchagent to enable Dash ZMQ by feature flag.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)