Skip to content

Move timestamps out of counter table to avoid update too frequently#3585

Merged
prsunny merged 1 commit intosonic-net:masterfrom
stephenxs:move-time-stamp-out-of-counter
Apr 18, 2025
Merged

Move timestamps out of counter table to avoid update too frequently#3585
prsunny merged 1 commit intosonic-net:masterfrom
stephenxs:move-time-stamp-out-of-counter

Conversation

@stephenxs
Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs commented Apr 1, 2025

What I did

The timestamp of PFC watchdog polling is moved out of the COUNTER table. The PFC watchdog Lua plugin should be adjusted accordingly.

Why I did it

How I verified it

Details if related

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from d608765 to a14cca5 Compare April 3, 2025 14:11
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from a14cca5 to dbc7a71 Compare April 4, 2025 01:03
@stephenxs stephenxs marked this pull request as ready for review April 4, 2025 01:03
@stephenxs stephenxs requested a review from kperumalbfn as a code owner April 4, 2025 01:03
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Copy Markdown
Collaborator Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator Author

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn could you please check my reply? Thanks

@stephenxs
Copy link
Copy Markdown
Collaborator Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@stephenxs stephenxs requested a review from kperumalbfn April 9, 2025 04:26
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link
Copy Markdown
Contributor

kperumalbfn commented Apr 10, 2025

Thanks @stephenxs Could you link the sairedis PR as well?

@stephenxs
Copy link
Copy Markdown
Collaborator Author

Thanks @stephenxs Could you link the sairedis PR as well?

Hi @kperumalbfn

sonic-net/sonic-sairedis#1567

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from dbc7a71 to 11e2338 Compare April 11, 2025 08:14
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from 11e2338 to a1b84b2 Compare April 12, 2025 08:16
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from a1b84b2 to 7bcf0a7 Compare April 15, 2025 15:07
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock merge.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from 1cdc289 to fdffcec Compare April 18, 2025 00:32
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 1552e34 into sonic-net:master Apr 18, 2025
15 checks passed
@stephenxs stephenxs deleted the move-time-stamp-out-of-counter branch April 18, 2025 23:13
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#72

@r12f
Copy link
Copy Markdown

r12f commented Apr 28, 2025

hi @kperumalbfn , do we need this for 202412? looks like a good change to add.

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#75

@kperumalbfn
Copy link
Copy Markdown
Contributor

hi @kperumalbfn , do we need this for 202412? looks like a good change to add.

@r12f This change will be good for optimization.

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
…onic-net#3585)

* Move timestamps out of counter table to avoid update too frequently (sonic-net#3585)

What I did

The timestamp of PFC watchdog polling is moved out of the COUNTER table. The PFC watchdog Lua plugin should be adjusted accordingly.
baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request Feb 23, 2026
…onic-net#3585)

* Move timestamps out of counter table to avoid update too frequently (sonic-net#3585)

What I did

The timestamp of PFC watchdog polling is moved out of the COUNTER table. The PFC watchdog Lua plugin should be adjusted accordingly.

Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants