Adding `HaOrch` for smartswitch dpu#3550

Merged

prsunny merged 62 commits intosonic-net:masterfrom

zjswhhh:ha_orch

May 6, 2025

Contributor

zjswhhh commented Mar 10, 2025 •

edited

Loading

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

How did I verify?
UTs:

[----------] 9 tests from DashHaOrchTest
[ RUN      ] DashHaOrchTest.AddRemoveHaSet
[       OK ] DashHaOrchTest.AddRemoveHaSet (10 ms)
[ RUN      ] DashHaOrchTest.HaSetAlreadyExists
[       OK ] DashHaOrchTest.HaSetAlreadyExists (11 ms)
[ RUN      ] DashHaOrchTest.AddRemoveHaScope
[       OK ] DashHaOrchTest.AddRemoveHaScope (11 ms)
[ RUN      ] DashHaOrchTest.AddRemoveEniHaScope
[       OK ] DashHaOrchTest.AddRemoveEniHaScope (11 ms)
[ RUN      ] DashHaOrchTest.NoHaSetFound
[       OK ] DashHaOrchTest.NoHaSetFound (11 ms)
[ RUN      ] DashHaOrchTest.SetHaScopeHaRole
[       OK ] DashHaOrchTest.SetHaScopeHaRole (11 ms)
[ RUN      ] DashHaOrchTest.SetHaScopeActivateRoleRequest
[       OK ] DashHaOrchTest.SetHaScopeActivateRoleRequest (11 ms)
[ RUN      ] DashHaOrchTest.SetHaScopeFlowReconcileRequest
[       OK ] DashHaOrchTest.SetHaScopeFlowReconcileRequest (11 ms)
[ RUN      ] DashHaOrchTest.InvalidInput
[       OK ] DashHaOrchTest.InvalidInput (11 ms)
[----------] 9 tests from DashHaOrchTest (100 ms total)

TODO:
2. ~~add support to set ha_scope attribute ha_role~~
3. event notifications handling (new PR)
4. Bulk create/remove (new PR)
5. Ha stats (new PR)

sign-off: Jing Zhang [email protected]

zjswhhh added 5 commits

March 10, 2025 05:51


          create/remove haset and hascope

04811ce


          makefile

d0122de


          haorch init

ba172ef


          update comment

81674c9


          init sai api

4d4e76f

Collaborator

mssonicbld commented Mar 10, 2025

/azp run

azure-pipelines bot commented Mar 10, 2025

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.


          set scope id to eni

dacff67

Collaborator

mssonicbld commented Mar 17, 2025

/azp run

azure-pipelines bot commented Mar 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          use DPU_APPL_DB

d4228b9

Collaborator

mssonicbld commented Mar 17, 2025

/azp run

azure-pipelines bot commented Mar 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          use dpu_appl_db

f6cdfe2

Collaborator

mssonicbld commented Mar 17, 2025

/azp run

azure-pipelines bot commented Mar 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          add set ha scope attributes

b8da370

Collaborator

mssonicbld commented Mar 21, 2025

/azp run

azure-pipelines bot commented Mar 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

zjswhhh added 2 commits

March 23, 2025 22:38


          add zmq producer tables

3b293c7


          use a specific build of swss-common cause dependency is not merged yet

e916546

Collaborator

mssonicbld commented Mar 30, 2025

/azp run

azure-pipelines bot commented Mar 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          use specific build of dash api

492f7bb

Collaborator

mssonicbld commented Mar 30, 2025

/azp run

azure-pipelines bot commented Mar 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          typo

6a4c882

Collaborator

mssonicbld commented Mar 30, 2025

/azp run

azure-pipelines bot commented Mar 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          typos

ccfe0c9

zjswhhh added 2 commits

May 2, 2025 00:25


          more UTs

1b1d8d6


          add gnmi feedback

01d9544

Collaborator

mssonicbld commented May 2, 2025

/azp run

azure-pipelines bot commented May 2, 2025

Azure Pipelines successfully started running 1 pipeline(s).

zjswhhh requested review from prabhataravind and theasianpianist

May 2, 2025 18:32


          Merge branch 'master' of https://github.com/sonic-net/sonic-swss into…

473638a

… ha_orch

Collaborator

mssonicbld commented May 2, 2025

/azp run

azure-pipelines bot commented May 2, 2025

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

prsunny commented May 5, 2025

@zjswhhh , looks like the PR is addressed for all comments. Could you fix coverage?
@r12f for viz


          last try on the coverage

772a766

zjswhhh force-pushed the ha_orch branch from f977fb2 to 772a766 Compare

May 5, 2025 22:02

Collaborator

mssonicbld commented May 5, 2025

/azp run

azure-pipelines bot commented May 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).


          Merge branch 'master' of https://github.com/sonic-net/sonic-swss into…

… ha_orch

Collaborator

mssonicbld commented May 5, 2025

/azp run

azure-pipelines bot commented May 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

zjswhhh commented May 6, 2025

Hi @prsunny - fixed the coverage.

Collaborator

prsunny commented May 6, 2025

@theasianpianist , can you approve?

theasianpianist approved these changes

View reviewed changes

prsunny approved these changes

View reviewed changes

prsunny merged commit 72eafd9 into sonic-net:master

15 checks passed

zjswhhh deleted the ha_orch branch

May 7, 2025 07:01

prabhataravind pushed a commit to prabhataravind/sonic-swss that referenced this pull request


          Adding HaOrch for smartswitch dpu (sonic-net#3550)

669191e

* Adding `HaOrch` for smartswitch dpu (sonic-net#3550)
* Create/remove haset and hascope

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

divyagayathri-hcl added a commit to divyagayathri-hcl/sonic-swss that referenced this pull request


          Revert "Adding HaOrch for smartswitch dpu (sonic-net#3550)"

61d41fd

divyagayathri-hcl added a commit to divyagayathri-hcl/sonic-swss that referenced this pull request


          Reapply "Adding HaOrch for smartswitch dpu (sonic-net#3550)"

e2f1209

divyagayathri-hcl pushed a commit to divyagayathri-hcl/sonic-swss that referenced this pull request


          Adding HaOrch for smartswitch dpu (sonic-net#3550)

97d5e74

* Adding `HaOrch` for smartswitch dpu (sonic-net#3550)
* Create/remove haset and hascope

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request


          Adding HaOrch for smartswitch dpu (sonic-net#3550)

26cf264

* Adding `HaOrch` for smartswitch dpu (sonic-net#3550)
* Create/remove haset and hascope

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

balanokia pushed a commit to balanokia/sonic-swss that referenced this pull request


          Adding HaOrch for smartswitch dpu (sonic-net#3550)

ab1c78b

* Adding `HaOrch` for smartswitch dpu (sonic-net#3550)
* Create/remove haset and hascope

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

baorliu pushed a commit to baorliu/sonic-swss that referenced this pull request


          Adding HaOrch for smartswitch dpu (sonic-net#3550)

7ba7f9c

* Adding `HaOrch` for smartswitch dpu (sonic-net#3550)
* Create/remove haset and hascope

HLD:
https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md

Requires:
sonic-net/sonic-swss-common#985
sonic-net/sonic-dash-api#33

Signed-off-by: Baorong Liu <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet