[action] [PR:3394] Added change not to create ECMP Group in SAI and program the route if none of ECMP members are active/link-up#3522
Merged
mssonicbld merged 1 commit intosonic-net:202411from Feb 19, 2025
Conversation
… none of ECMP members are active/link-up What I did: Added change not to create ECMP Group in SAI and program the route if none of the ECMP members are active/link-up. Also do not program the Temp Route if Neigh is not active (Link Down) Also as part of this change if Route is not programmed and if we remove that route than decrement VRF Reference count in `removeRoute` as `removeRoutePost` will not be called in this case. Why I did: In scale setup of T2 it's possible all links can go down simultaneously which case we can get Route messages with all nexthops being in down state. In such case we might create empty Nexthop Group in SAI for the given route which causes not needed SAI call for Nexthop Group creation and also create traffic blackhole for the route where that route can still forward traffic via default route if eligible/applicable. Also in this case no point to add Temp Route if neighbor is link down. How I verify: 1. Compile time test was failing because of this chnage so added oper_status as UP in the mock tests 2. Modified subport router interface UT for this scenario. 3. Ixia Convergence tests Reference to full context of this changes: [Swss_route_enhancemnts.docx](https://github.com/user-attachments/files/18149172/Swss_route_enhancemnts.docx)
Collaborator
Author
|
Original PR: #3394 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
May 3, 2025
… none of ECMP members are active/link-up (sonic-net#3522) What I did: Added change not to create ECMP Group in SAI and program the route if none of the ECMP members are active/link-up. Also do not program the Temp Route if Neigh is not active (Link Down) Also as part of this change if Route is not programmed and if we remove that route than decrement VRF Reference count in `removeRoute` as `removeRoutePost` will not be called in this case. Why I did: In scale setup of T2 it's possible all links can go down simultaneously which case we can get Route messages with all nexthops being in down state. In such case we might create empty Nexthop Group in SAI for the given route which causes not needed SAI call for Nexthop Group creation and also create traffic blackhole for the route where that route can still forward traffic via default route if eligible/applicable. Also in this case no point to add Temp Route if neighbor is link down. How I verify: 1. Compile time test was failing because of this chnage so added oper_status as UP in the mock tests 2. Modified subport router interface UT for this scenario. 3. Ixia Convergence tests Reference to full context of this changes: [Swss_route_enhancemnts.docx](https://github.com/user-attachments/files/18149172/Swss_route_enhancemnts.docx)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Added change not to create ECMP Group in SAI and program the route if none of the ECMP members are active/link-up.
Also do not program the Temp Route if Neigh is not active (Link Down)
Also as part of this change if Route is not programmed and if we remove that route than decrement VRF Reference count in
removeRouteasremoveRoutePostwill not be called in this case.Why I did:
In scale setup of T2 it's possible all links can go down simultaneously which case we can get Route messages with all nexthops being in down state. In such case we might create empty Nexthop Group in SAI for the given route which causes not needed SAI call for Nexthop Group creation and also create traffic blackhole for the route where that route can still forward traffic via default route if eligible/applicable.
Also in this case no point to add Temp Route if neighbor is link down.
How I verify:
Reference to full context of this changes:
Swss_route_enhancemnts.docx