Added Change to Skip Route Programming if NH is link/oper down#3520
Merged
prsunny merged 6 commits intosonic-net:masterfrom Feb 24, 2025
Merged
Added Change to Skip Route Programming if NH is link/oper down#3520prsunny merged 6 commits intosonic-net:masterfrom
prsunny merged 6 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
deepak-singhal0408
approved these changes
Feb 20, 2025
prsunny
reviewed
Feb 20, 2025
| return false; | ||
| } | ||
| } | ||
| else if (m_neighOrch->isNextHopFlagSet(nexthop, NHFLAGS_IFDOWN)) |
Collaborator
There was a problem hiding this comment.
Just thinking if it impact tunnel route in dualtor case if NHFLAG is down? @Ndancejic , can you check this change?
Contributor
There was a problem hiding this comment.
I think tunnel routes should be safe, I believe line 1839 would catch interface nexthops. also I think routes to tunnel nh get skipped in doTask:
/* skip direct routes to tun0 */
else if (alsv[0] == "tun0")
{
it = consumer.m_toSync.erase(it);
}
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ndancejic
approved these changes
Feb 22, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit ac88093.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Feb 24, 2025
Contributor
Author
|
@arlakshm added label for msft/202405 |
Contributor
|
@abdosi, looks like there is a cherry-pick conflict |
Contributor
|
@abdosi could you resolve the conflicts for 202411 |
|
Hi @abdosi , I wonder if you could help with the cherry pick to 202411? Once it lands there, it will be automatically merged into 202412. |
|
Creating change directly to 202412 will create a merge conflict in later merges and break the automation. : D |
arlakshm
added a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Feb 28, 2025
What I did: Cherry-Pick of PR: sonic-net/sonic-swss#3520
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…-net#3520) *What I did: Added Change to Skip Route Programming if NH is link/oper down. With Scale Route testing of 60K+ routes when we toggle all the interfaces[14+ interface back to back] as done here: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snappi_tests/multidut/bgp/test_bgp_outbound_uplink_multi_po_flap.py we see because of slowness of FRR Route APP_DB processing compare to Link Notification Handling where we have updated the Nexthop Group as part of Link Notification handling to point to default route via sonic-net#3389 [if eligible] FRR slowness can reprogram the Route back to Nexthop which is link down. This change is similar to sonic-net#3394 which was done for Nexthop Group.
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
…-net#3520) *What I did: Added Change to Skip Route Programming if NH is link/oper down. With Scale Route testing of 60K+ routes when we toggle all the interfaces[14+ interface back to back] as done here: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snappi_tests/multidut/bgp/test_bgp_outbound_uplink_multi_po_flap.py we see because of slowness of FRR Route APP_DB processing compare to Link Notification Handling where we have updated the Nexthop Group as part of Link Notification handling to point to default route via sonic-net#3389 [if eligible] FRR slowness can reprogram the Route back to Nexthop which is link down. This change is similar to sonic-net#3394 which was done for Nexthop Group. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Added Change to Skip Route Programming if NH is link/oper down. With Scale Route testing of 60K+ routes when we toggle all the interfaces[14+ interface back to back] as done here: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snappi_tests/multidut/bgp/test_bgp_outbound_uplink_multi_po_flap.py we see because of slowness of FRR Route APP_DB processing compare to Link Notification Handling where we have updated the Nexthop Group as part of Link Notification handling to point to default route via #3389 [if eligible] FRR slowness can reprogram the Route back to Nexthop which is link down.
This change is similar to #3394 which was done for Nexthop Group.
How I verify:
Manual Verification and Ixia tetsing
Also UT has been updated to make sure it passes after this change.