[AclOrch] Custom ACL Based Metering#3484
Open
shaygol wants to merge 4 commits intosonic-net:masterfrom
Open
Conversation
Collaborator
|
/azp run |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Please provide the HLD link in PR description |
Collaborator
|
@shaygol , could you please rebase? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- New 'AclRule' subclass: 'AclRulePolicer' - ACL rule table schema update - Unit Tests
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
micas-net
reviewed
May 22, 2025
|
|
||
| sai_acl_entry_attr_t action; | ||
|
|
||
| const auto it = aclPolicerActionLookup.find(attr_name); |
There was a problem hiding this comment.
The validation here might not be necessary,
as the creation of the rule object in makeShared incidentally validates the policer action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added a mechanism integrating policers with ACL rules to provide granular traffic management.
Why I did it
To allow customers to enforce advanced traffic management policies.
How I verified it
Details if related
HLD link: Custom ACL Based Metering