Add heartbeat interval parameter.#3458
Merged
prsunny merged 8 commits intosonic-net:masterfrom Jan 31, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jan 14, 2025
orchagent/main.cpp
Outdated
| case 'I': | ||
| if (optarg) | ||
| { | ||
| g_heart_beat_interval = atoi(optarg); |
Contributor
Contributor
There was a problem hiding this comment.
Should we treat 0 as error? an invalid string will also lead to 0.
Contributor
Author
There was a problem hiding this comment.
0 means disable heartbeat feature
qiluo-msft
reviewed
Jan 14, 2025
orchagent/main.cpp
Outdated
| case 'I': | ||
| if (optarg) | ||
| { | ||
| g_heart_beat_interval = atoi(optarg); |
Contributor
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jan 28, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Add heart beat interval parameter * Disable feature when interval is 0 Why I did it Make this feature can be disable, because log spam issue on small disk device: sonic-net/sonic-buildimage#21157 Work item tracking Microsoft ADO: 30594076
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
* Add heart beat interval parameter * Disable feature when interval is 0 Why I did it Make this feature can be disable, because log spam issue on small disk device: sonic-net/sonic-buildimage#21157 Work item tracking Microsoft ADO: 30594076 Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add heartbeat interval parameter.
Why I did it
Make this feature can be disable, because log spam issue on small disk device:
sonic-net/sonic-buildimage#21157
Work item tracking
How I did it
Add heartbeat interval parameter. and disable heartbeat when interval is 0.
How to verify it
Pass all UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add heartbeat interval parameter.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)