Remove update of mgmt oper status in swss by SuvarnaMeenakshi · Pull Request #3439 · sonic-net/sonic-swss

SuvarnaMeenakshi · 2024-12-20T17:27:45Z

What I did
Issue to be fix: Currently operational status of mgmt interface is not present or correct for multi-asic devices.

Why I did it
Initial PR that added mgmt oper status feature in swss: #630
sonic-net/sonic-buildimage#21245 adds a script to update oper status of management interface periodically. In doing so, we no longer need to update oper status of mgmt interface in swss.

How I verified it
Verified on single-asic platform

verified on single-asic platform and multi-asic Chassis platfrom.
Single ASIC Arista device verification along with Add script to periodically update oper status of management interface sonic-buildimage#21245 changes
Ran the below bash script to verify the state of STATE_DB: MGMT_OPER_STATUS table and also execute config_reload, verify if STATE_DB is flushed out and repopulated after monit starts periodic script.

#!/bin/bash
CUR_STATUS=`sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"`
echo "current status in STATE_DB is $CUR_STATUS :: expected to have up state"
snmp_result=`docker exec snmp snmpwalk -v2c -c <comm> <IP> 1.3.6.1.2.1.2.2.1.8.10000`
echo "snmp result  before config reload 5min $snmp_result :: expected to have 1 in snmp result"
sudo config reload -y
CUR_STATUS=`sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"`
echo "current status in STATE_DB after config_reload is $CUR_STATUS :: expected to have empty"
# sleep for snmp to start
sleep 60
snmp_result=`docker exec snmp snmpwalk -v2c -c <comm> <IP> 1.3.6.1.2.1.2.2.1.8.10000`
echo "snmp result  after config reload $snmp_result :: expected to return error since STATE_DB is not yet populated"
# monit will populate mgmt oper status after each 5min cycle
sleep 240
CUR_STATUS=`sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"`
echo "current status in STATE_DB after config_reload after 5min $CUR_STATUS :: expected to have up state"
snmp_result=`docker exec snmp snmpwalk -v2c -c <comm> <IP> 1.3.6.1.2.1.2.2.1.8.10000`
echo "snmp result  after config reload after 5min $snmp_result :: expected to have 1 in snmp result"

Result of above script:

current status in STATE_DB is {'oper_status': 'up'} :: expected to have up state
snmp result  before config reload 5min iso.3.6.1.2.1.2.2.1.8.10000 = INTEGER: 1 :: expected to have 1 in snmp result
Acquired lock on /etc/sonic/reload.lock
Disabling container and routeCheck monitoring ...
Stopping SONiC target ...
Running command: /usr/local/bin/sonic-cfggen -j /etc/sonic/init_cfg.json -j /etc/sonic/config_db.json --write-to-db
Running command: /usr/local/bin/db_migrator.py -o migrate
Running command: /usr/local/bin/sonic-cfggen -d -y /etc/sonic/sonic_version.yml -t /usr/share/sonic/templates/sonic-environment.j2,/etc/sonic/sonic-environment
Restarting SONiC target ...
Enabling container and routeCheck monitoring ...
Reloading Monit configuration ...
Reinitializing monit daemon
Released lock on /etc/sonic/reload.lock
current status in STATE_DB after config_reload is {} :: expected to have empty
snmp result  after config reload iso.3.6.1.2.1.2.2.1.8.10000 = No Such Object available on this agent at this OID :: expected to return error since STATE_DB is not yet populated
current status in STATE_DB after config_reload after 5min {'oper_status': 'up'} :: expected to have up state
snmp result  after config reload after 5min iso.3.6.1.2.1.2.2.1.8.10000 = INTEGER: 1 :: expected to have 1 in snmp result

Details if related

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

mssonicbld · 2024-12-20T17:27:47Z

/azp run

azure-pipelines · 2024-12-20T17:27:58Z

Azure Pipelines successfully started running 1 pipeline(s).

gechiang

LGTM.

prsunny · 2025-01-02T21:31:13Z

@SuvarnaMeenakshi , could you link the original PR that added this feature? Is there any other dependency that we've to address?

SuvarnaMeenakshi · 2025-01-02T21:35:44Z

@SuvarnaMeenakshi , could you link the original PR that added this feature? Is there any other dependency that we've to address?

hi @prsunny this is the PR that added this feature: #630

prsunny · 2025-01-06T19:03:46Z

portsyncd/linksync.cpp

    {
        string key = idx_p->if_name;

-        /* Explicitly store management ports oper status into the state database.


Why do we need to keep the for loop as this was also added as part of #630

Yes, we don't need this, removed to match initial PR changes

prsunny · 2025-01-06T19:06:43Z

portsyncd/linksync.cpp

                       nlmsg_type, key.c_str(), admin, oper, addrStr, ifindex, master);
    }

-    if (!key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX))


I think we should remove the check at line 134 as well

Removed this : key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX)

arlakshm · 2025-01-08T01:20:17Z

@SuvarnaMeenakshi, can you please address the comments?

in PR sonic-net#630 Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

mssonicbld · 2025-01-08T02:07:28Z

/azp run

azure-pipelines · 2025-01-08T02:07:38Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-08T17:31:03Z

/azp run

azure-pipelines · 2025-01-08T17:31:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-08T22:59:10Z

/azp run

azure-pipelines · 2025-01-08T22:59:20Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-10T03:17:44Z

Cherry-pick PR to msft-202405: Azure/sonic-swss.msft#20

Currently operational status of mgmt interface is not present or correct for multi-asic devices. Why I did it Initial PR that added mgmt oper status feature in swss: sonic-net#630 sonic-net/sonic-buildimage#21245 adds a script to update oper status of management interface periodically. In doing so, we no longer need to update oper status of mgmt interface in swss. --------- Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

This reverts commit 6f30ddd.

Currently operational status of mgmt interface is not present or correct for multi-asic devices. Why I did it Initial PR that added mgmt oper status feature in swss: sonic-net#630 sonic-net/sonic-buildimage#21245 adds a script to update oper status of management interface periodically. In doing so, we no longer need to update oper status of mgmt interface in swss. --------- Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Currently operational status of mgmt interface is not present or correct for multi-asic devices. Why I did it Initial PR that added mgmt oper status feature in swss: sonic-net#630 sonic-net/sonic-buildimage#21245 adds a script to update oper status of management interface periodically. In doing so, we no longer need to update oper status of mgmt interface in swss. --------- Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com> Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>

Remove update of mgmt oper status in swss

03f60ad

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi requested a review from prsunny as a code owner December 20, 2024 17:27

SuvarnaMeenakshi requested review from abdosi and qiluo-msft December 20, 2024 17:28

gechiang approved these changes Dec 20, 2024

View reviewed changes

prsunny reviewed Jan 6, 2025

View reviewed changes

arlakshm added the Request for msft-202405 Branch label Jan 8, 2025

Fix as per review comments to cleanly remove changes added

e42b344

in PR sonic-net#630 Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Merge branch 'master' into mgmt_oper

ad67960

rlhui added the P0 label Jan 8, 2025

rlhui assigned SuvarnaMeenakshi Jan 8, 2025

Merge branch 'master' into mgmt_oper

04869bb

prsunny approved these changes Jan 9, 2025

View reviewed changes

rlhui merged commit 6f30ddd into sonic-net:master Jan 10, 2025

arlakshm added the Approved for msft-202405 Branch label Jan 10, 2025

mssonicbld mentioned this pull request Jan 10, 2025

[action] [PR:3439] Remove update of mgmt oper status in swss Azure/sonic-swss.msft#20

Merged

mssonicbld added the Created PR to msft-202405 Branch label Jan 10, 2025

arlakshm added the Included in msft-202405 Branch label Jan 15, 2025

muhammadalihussnain added a commit to ridahanif96/sonic-swss that referenced this pull request Aug 4, 2025

Revert "Remove update of mgmt oper status in swss (sonic-net#3439)"

84b1292

This reverts commit 6f30ddd.

Conversation

SuvarnaMeenakshi commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Dec 20, 2024

Uh oh!

azure-pipelines bot commented Dec 20, 2024

Uh oh!

gechiang left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jan 2, 2025

Uh oh!

SuvarnaMeenakshi commented Jan 2, 2025

Uh oh!

prsunny Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

prsunny Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

arlakshm commented Jan 8, 2025

Uh oh!

mssonicbld commented Jan 8, 2025

Uh oh!

azure-pipelines bot commented Jan 8, 2025

Uh oh!

mssonicbld commented Jan 8, 2025

Uh oh!

azure-pipelines bot commented Jan 8, 2025

Uh oh!

mssonicbld commented Jan 8, 2025

Uh oh!

azure-pipelines bot commented Jan 8, 2025

Uh oh!

mssonicbld commented Jan 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SuvarnaMeenakshi commented Dec 20, 2024 •

edited

Loading