Merged
Conversation
Alert mode tells watchdog that whenever it detects PFC storm, it should only write message to the log. It is implemented as a separate action along with drop and forward. Signed-off-by: marian-pritsak <marianp@mellanox.com>
lguohan
approved these changes
Oct 10, 2017
sihuihan88
approved these changes
Oct 10, 2017
stcheng
reviewed
Oct 11, 2017
| { | ||
| { "forward", PfcWdAction::PFC_WD_ACTION_FORWARD }, | ||
| { "drop", PfcWdAction::PFC_WD_ACTION_DROP }, | ||
| { "alert", PfcWdAction::PFC_WD_ACTION_ALERT }, |
Contributor
There was a problem hiding this comment.
is it better to move this const into the header file?
Collaborator
Author
There was a problem hiding this comment.
It is not intended to be used by anyone else. Enum is in header.
Contributor
There was a problem hiding this comment.
then a const static is better? do you know if the compiler will optimize here to only initialize the variable once?
Contributor
There was a problem hiding this comment.
const static will be better here. Move out of this function, and make it a cpp global is even better.
There are several cost here:
- time cost: each function call will call the instructor once
- space cost: each template instantiate will create a local map instance
Contributor
|
In this pr, in alert mode, it will run restore plugins for stormed queues, which is not correct. Instead, we need to use detect plugin to check stormed queues in alert mode. #343 includes the enhancement. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* require root privilege for all pfcwd configuration commands (sonic-net#330) Signed-off-by: Guohan Lu <gulv@microsoft.com> * pfcwd start: 1) default restoration time to 2 times detection time if not defined; 2) check if options are prefixed with "--"; Signed-off-by: Wenda <wenni@microsoft.com> * Check if ports list has invalid string element; Correct typo restoration-time Signed-off-by: Wenda <wenni@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
* Change get_tx_bias return type to list Signed-off-by: Mihir Patel <patelmi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alert mode tells watchdog that whenever it detects PFC storm, it should
only write message to the log. It is implemented as a separate action
along with drop and forward.
Signed-off-by: marian-pritsak marianp@mellanox.com