intfsyncd neighsyncd: Ignoring lo, eth0 and docker0 interfaces#34
intfsyncd neighsyncd: Ignoring lo, eth0 and docker0 interfaces#34stcheng wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
|
||
| /* Don't sync lo, eth0, and docker0 routes */ | ||
| if (key == "lo" || key == "eth0" || key == "docker0") | ||
| return; |
There was a problem hiding this comment.
these are hardcoded values. Can you check if the key in the your front panel port list? That's more generic. as in some platform they may have other interfaces such as eth1, ... etc.
There was a problem hiding this comment.
Then we need to get the list of ports, lags and vlans during the runtime. For now hard coded values can solve the issue but later we might have to discuss about what approach is better.
There was a problem hiding this comment.
for interface sync, we need to get lo address into the swss. This is becasue we are putting bgp loopback IP address on interface lo, and this one needs to be in the ASIC in order to trap all IP packets destined to bgp loopback address.
In reply to: 65829595 [](ancestors = 65829595)
There was a problem hiding this comment.
why not pass them the swss and let the orch agent to figure out? In our design, the apps are independent probably not a good place to figure out the list of ports, lags and vlans during the runtime.
In reply to: 65829595 [](ancestors = 65829595)
|
🕐 |
Co-authored-by: Vasant <[email protected]>
```<br>* c97d84dd - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 (2025-02-16) [Sonic Automation] * 5031aad - (origin/202411) Capability query for MACSEC ACL attribute (#3511) (2025-02-12) [mssonicbld] * 4b357e5 - Fix VRF update handling for loopback interfaces in IntfsOrch (#3512) (2025-02-12) [mssonicbld] * fe98176 - Add a delay between killing teamd processes (#3510) (2025-02-11) [mssonicbld] * e967711 - Remove RIF from m_rifsToAdd before deleting it (#3499) (2025-02-07) [mssonicbld] * 337c9a1 - Optimize counter polling interval by making it more accurate (#3500) (2025-02-07) [mssonicbld]<br>```
addRoutePost() assumes the VRF is already added and attempts to get the VRF ID for the same and used it to lookup the route entry. Since the VRF is not yet created, exception gets thrown. When the VRF is not yet created, the route add can be postponed for the VRF to be created first.
…sonic-net#34) - Use json.hpp to construct the JSON data and store into the m_dumpFile, which could be used as input file for swssconfig. - Add unit test for verification
2 participants
With this fix, we will only have the entries that we care appearing in the database. This allows the APP_DB to be synced with ASIC_DB and both contents draw the same picture.