[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL by bradh352 · Pull Request #3383 · sonic-net/sonic-swss

bradh352 · 2024-11-20T14:41:02Z

What I did

This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk.

The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible:

# show vxlan remotevtep
+------------+------------+-------------------+--------------+
| SIP        | DIP        | Creation Source   | OperStatus   |
+============+============+===================+==============+
| 172.16.0.1 | 172.16.0.2 | EVPN              | oper_down    |
+------------+------------+-------------------+--------------+
Total count : 1

The remote VTEP is really up.

Original PR for that is #2080.

Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging.

The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is #3216, however it appears it has its origins in
sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3

Why I did it

Fixes #3216
Fixes #2080
Fixes sonic-net/sonic-buildimage#10050
Fixes sonic-net/sonic-buildimage#10004

How I verified it

Pulled into my private sonic-swss fork:
https://github.com/bradh352/sonic-swss/commits/bradh352/master

Which is pulled in by my private sonic-buildimage fork:
https://github.com/bradh352/sonic-buildimage/tree/bradh352/master

Which is then automatically built when changes are made. Then the uploaded asset of sonic-broadcom.bin is installed onto Dell S5248F switches and tested.

Update: also now tested by me on Mellanox/NVidia SN2201

Details if related

Signed-off-by: Brad House (@bradh352)

This should also be backported to 202411, 202405

linux-foundation-easycla · 2024-11-20T14:41:22Z

The committers listed above are authorized under a signed CLA.

✅ login: bradh352 / name: Brad House (bc528b6, f461115, 4149ce5, 74238d1)
✅ login: prsunny / name: Prince Sunny (7ea6c7f)

VladimirKuk

Looks good to me

bradh352 · 2024-11-20T20:34:31Z

@VladimirKuk any idea if those test failures are actually a symptom of the patch itself? Or is it just common for things to fail in the tests from time to time?

VladimirKuk · 2024-11-20T22:04:49Z

Tests do fail from time to time.
At least to me, these tests are unrelated to the change.

bradh352 · 2024-11-20T23:32:32Z

@prsunny please review

lukasstockner · 2024-11-27T19:25:00Z

Thank you for pushing this forward!
For the record, we've been running these changes in production for ~2 years without issues, so I'd be quite confident that they work as expected.

bradh352 · 2024-11-27T20:37:59Z

@prsunny ping

bradh352 · 2024-12-04T17:17:34Z

@VladimirKuk I ended up having to sprinkle your suggestion in 2 places to get it fully working.

orchagent/vxlanorch.cpp

bradh352 · 2024-12-07T11:04:19Z

@prsunny how would you like to proceed on this? I think this is a critical issue since community SONiC doesn't support ARP/ND suppression so things just don't work at all without this.

mssonicbld · 2024-12-13T14:11:35Z

/azp run

azure-pipelines · 2024-12-13T14:11:46Z

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 · 2024-12-13T14:12:20Z

@prsunny looks like the internal msconflict is resolved now since pvst was merged to main. Please review and hopefully merge. Thanks!

mssonicbld · 2024-12-16T16:03:13Z

/azp run

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

…TTL (sonic-net#3383)" This reverts commit e181e3c.

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```

@VladimirKuk

…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` Signed-off-by: Baorong Liu <[email protected]>

bradh352 requested a review from prsunny as a code owner November 20, 2024 14:41

bradh352 force-pushed the vxlan-fixes branch 2 times, most recently from 603980f to 75c4f03 Compare November 20, 2024 14:49

This was referenced Nov 20, 2024

VxLAN fix tunnel oper_state issue #3216

Closed

Set tunnel id to saiOidToAlias for support update tunnel status. #2080

Closed

VladimirKuk reviewed Nov 20, 2024

View reviewed changes

bradh352 mentioned this pull request Nov 20, 2024

NEIGH_TABLE not populated with VXLAN routes #3384

Closed

bradh352 force-pushed the vxlan-fixes branch from 24f3487 to 3a80323 Compare December 4, 2024 16:58

bradh352 requested review from abdosi and judyjoseph as code owners December 4, 2024 16:58

bradh352 force-pushed the vxlan-fixes branch 3 times, most recently from 1ad6c1e to 89b365a Compare December 4, 2024 17:16

bradh352 mentioned this pull request Dec 5, 2024

[frr/bgpd] unified config missing fpm option breaking VXLAN EVPN sonic-net/sonic-buildimage#21034

Closed

VladimirKuk approved these changes Dec 5, 2024

View reviewed changes

prsunny reviewed Dec 5, 2024

View reviewed changes

orchagent/vxlanorch.cpp Show resolved Hide resolved

prsunny force-pushed the master branch from d098ac8 to fa2b530 Compare December 11, 2024 18:22

bradh352 force-pushed the vxlan-fixes branch from a000ef4 to 6a9f067 Compare December 16, 2024 16:03

stepanblyschak added a commit to stepanblyschak/sonic-swss that referenced this pull request Feb 10, 2025

Revert "[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation …

27b1a82

…TTL (sonic-net#3383)" This reverts commit e181e3c.

This was referenced Feb 10, 2025

[Internal] Revert "[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation … stepanblyschak/sonic-swss#49

Closed

warm/fast-reboot fails on latest master due to error in PortsOrch::bake(): Invalid port table sonic-net/sonic-buildimage#21688

Closed

bradh352 mentioned this pull request Feb 10, 2025

portsorch: don't call updateDbPortOperStatus on all port types #3505

Merged

dal00 mentioned this pull request Sep 11, 2025

orchagent: VTEP stuck in oper_down kamelnetworks/sonic-buildimage#11

Open

Conversation

bradh352 commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VladimirKuk left a comment

Choose a reason for hiding this comment

Uh oh!

bradh352 commented Nov 20, 2024

Uh oh!

VladimirKuk commented Nov 20, 2024

Uh oh!

bradh352 commented Nov 20, 2024

Uh oh!

lukasstockner commented Nov 27, 2024

Uh oh!

bradh352 commented Nov 27, 2024

Uh oh!

bradh352 commented Dec 4, 2024

Uh oh!

Uh oh!

bradh352 commented Dec 7, 2024

Uh oh!

mssonicbld commented Dec 13, 2024

Uh oh!

azure-pipelines bot commented Dec 13, 2024

Uh oh!

bradh352 commented Dec 13, 2024

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bradh352 commented Nov 20, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 20, 2024 •

edited

Loading