[portsyncd]: Add producer for state database updates by stcheng · Pull Request #336 · sonic-net/sonic-swss

stcheng · 2017-10-04T18:36:27Z

Add m_stateTableProducer to write to the state database once the ports are ready
Remove suffix Consumer in some variables since they are not 'consumers'

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

stcheng · 2017-10-04T18:36:58Z

@jipanyanga please check this pull request.

jipanyang · 2017-10-04T18:42:26Z

portsyncd/linksync.cpp

+            FieldValueTuple tuple("state", "TRUE");
+            vector<FieldValueTuple> vector;
+            vector.push_back(tuple);
+            m_stateTableProducer.set(key, vector);


The problem I see here is that it will update stateDB port table with ":" separator which is inconsistent with configDB.
It is a general problem, due to table separator is changed to "|" from ":" by sonic-py-swsssdk, all other C++ swss-common library which has fixed ":" table separator won't be able to work with configDB.

we should not use stateTableProducer, because we will not use stateTable Consumer to consume the data as it only supports one consumer.

I'll use Table class for now.

Could you update the change with latest Table class and use "|" for port state table in stateDB?

lguohan · 2017-10-25T10:15:39Z

portsyncd/portsyncd.cpp

-    ProducerStateTable p(&db, APP_PORT_TABLE_NAME);
+    DBConnector appl_db(APPL_DB, DBConnector::DEFAULT_UNIXSOCKET, 0);
+    DBConnector state_db(STATE_DB, DBConnector::DEFAULT_UNIXSOCKET, 0);
+    ProducerStateTable p(&appl_db, APP_PORT_TABLE_NAME);


use Table instead of producer state table.

lguohan · 2017-10-25T10:28:29Z

Can you check the #344 to add similiar output for this PR?

lguohan · 2017-10-25T10:31:58Z

portsyncd/linksync.cpp

+    m_vlanMemberTableProducer(appl_db, APP_VLAN_MEMBER_TABLE_NAME),
+    m_portTable(appl_db, APP_PORT_TABLE_NAME),
+    m_vlanMemberTable(appl_db, APP_VLAN_MEMBER_TABLE_NAME),
+    m_stateTableProducer(state_db, "PORT_TABLE")


-> m_statePortTable(state_db, STATE_PORT_TABLE_NAME, CONFIGDB_TABLE_NAME_SEPARATOR)

lguohan

use table instead of producer table class for state db write.

- Add m_statePortTable to write to the state database once the ports are ready - Remove suffix Consumer in some variables since they are not 'consumers' Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

stcheng · 2017-10-25T20:38:01Z

updated

lguohan

can you show the output of the state db after this patch?

lguohan · 2017-10-25T19:03:05Z

portsyncd/linksync.cpp

        if (!g_init && g_portSet.find(key) != g_portSet.end())
        {
            g_portSet.erase(key);
+            FieldValueTuple tuple("state", "TRUE");


stcheng · 2017-10-25T21:20:52Z

root@str-s6000-acs-7:/home/admin# redis-cli         
127.0.0.1:6379> select 6                            
OK                                                  
127.0.0.1:6379[6]> keys *                           
 1) "PORT_TABLE|Ethernet56"                         
 2) "PORT_TABLE|Ethernet96"                         
 3) "PORT_TABLE|Ethernet124"                        
 4) "PORT_TABLE|Ethernet24"                         
 5) "PORT_TABLE|Ethernet68"                         
 6) "PORT_TABLE|Ethernet0"                          
 7) "PORT_TABLE|Ethernet120"                        
 8) "PORT_TABLE|Ethernet112"                        
 9) "PORT_TABLE|Ethernet8"                          
10) "PORT_TABLE|Ethernet60"                         
11) "PORT_TABLE|Ethernet116"                        
12) "PORT_TABLE|Ethernet44"                         
13) "PORT_TABLE|Ethernet76"                         
14) "PORT_TABLE|Ethernet36"                         
15) "PORT_TABLE|Ethernet84"                         
16) "PORT_TABLE|Ethernet72"                         
17) "PORT_TABLE|Ethernet20"                         
18) "PORT_TABLE|Ethernet100"                        
19) "PORT_TABLE|Ethernet108"                        
20) "PORT_TABLE|Ethernet52"                         
21) "PORT_TABLE|Ethernet88"                         
22) "PORT_TABLE|Ethernet92"                         
23) "PORT_TABLE|Ethernet12"                         
24) "PORT_TABLE|Ethernet4"                          
25) "PORT_TABLE|Ethernet104"                        
26) "PORT_TABLE|Ethernet28"                         
27) "PORT_TABLE|Ethernet32"                         
28) "PORT_TABLE|Ethernet16"                         
29) "PORT_TABLE|Ethernet64"                         
30) "PORT_TABLE|Ethernet80"                         
31) "PORT_TABLE|Ethernet40"                         
32) "PORT_TABLE|Ethernet48"                         
127.0.0.1:6379[6]> hgetall "PORT_TABLE|Ethernet124" 
1) "state"                                          
2) "ok"

…) to construct producer g_asicState (sonic-net#336) * create RedisPipeline obj by default constructor , which enabled redispipeline with parameter 128 * create producer g_asicState using redisPipeline instance with redispipeline enabled * with the changes in swss and swss-common, route performance improved by 200~300 routes/sec

…d of hardcoded in a map (sonic-net#336)

stcheng requested a review from taoyl-ms October 4, 2017 18:36

jipanyang reviewed Oct 4, 2017

View reviewed changes

stcheng self-assigned this Oct 5, 2017

This was referenced Oct 21, 2017

configDB enforcer for VLAN #356

Merged

configDB enforcer for interface #357

Merged

lguohan reviewed Oct 25, 2017

View reviewed changes

lguohan requested changes Oct 25, 2017

View reviewed changes

stcheng force-pushed the portsyncd branch 2 times, most recently from 810a4c6 to 97a72a8 Compare October 25, 2017 18:50

[portsyncd]: Add producer for state database updates

31f36a5

- Add m_statePortTable to write to the state database once the ports are ready - Remove suffix Consumer in some variables since they are not 'consumers' Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

stcheng force-pushed the portsyncd branch from 97a72a8 to 31f36a5 Compare October 25, 2017 20:37

lguohan reviewed Oct 25, 2017

View reviewed changes

stcheng added the Enhancement ➕ label Oct 25, 2017

lguohan approved these changes Oct 25, 2017

View reviewed changes

lguohan merged commit e7741ca into sonic-net:master Oct 25, 2017

stcheng deleted the portsyncd branch October 25, 2017 21:29

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022

Remove explicit dependency on tabulate; Add comments (sonic-net#336)

9a139ab

jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025

[MultiDB]: Use table name separator from database_config.json, instea…

b2c6edd

…d of hardcoded in a map (sonic-net#336)

Conversation

stcheng commented Oct 4, 2017

Uh oh!

stcheng commented Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jipanyang Oct 4, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Oct 4, 2017

Choose a reason for hiding this comment

Uh oh!

stcheng Oct 5, 2017

Choose a reason for hiding this comment

Uh oh!

jipanyang Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Oct 25, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan commented Oct 25, 2017

Uh oh!

lguohan Oct 25, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

stcheng commented Oct 25, 2017

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

lguohan Oct 25, 2017

Choose a reason for hiding this comment

Uh oh!

stcheng commented Oct 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stcheng commented Oct 4, 2017 •

edited

Loading

stcheng commented Oct 25, 2017 •

edited

Loading