VOQ: Set the ECMP group size to 128.#3351
Merged
prsunny merged 4 commits intosonic-net:masterfrom Nov 11, 2024
Merged
Conversation
deepak-singhal0408
changed the title
prsunny
reviewed
Nov 4, 2024
Contributor
Author
|
@prsunny,
In future, once we have vslib support for this attribute, this code will automatically be covered during dvs bring up of virtual chassis (as this will get executed during swss init) This is to fix a regression on 202405 branch for voq chassis, hence request to expedite its merge. Thank you! |
deepak-singhal0408
changed the title
arlakshm
approved these changes
Nov 11, 2024
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Nov 13, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
Contributor
|
@deepak-singhal0408 Please add MSFT ADO number to the PR for 202405 cherry-pick. Thanks! |
Contributor
Author
|
MSFT ADO: 30182195 for 202405 branch.. @bingwang-ms |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Nov 18, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
Collaborator
|
Cherry-pick PR to 202405: #3376 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 19, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Nov 19, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
shiraez
pushed a commit
to Marvell-switching/sonic-swss
that referenced
this pull request
Feb 17, 2025
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Set the ECMP group size on VOQ platform to 128. Why I did it in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash. Related issue: sonic-net/sonic-buildimage#20622 Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Set the ECMP group size on VOQ platform to 128.
Why I did it
in SAI 11.x, the MAX ECMP group size on DNX chipsets is set to 64. This is causing issues on VOQ platforms, where ECMP group size in control plane (ebgp+ibgp) is set to 128. We see ECMP group creation failures and eventually leading to orchagent crash.
Related issue: sonic-net/sonic-buildimage#20622
How I verified it
Verified on T2 Chassis(VOQ) by adding Static Routes with > 64 nexthops.
Also tried shutting down on of the group member to verify.
Details if related
Syslogs:
NOTICE swss0#orchagent: :- RouteOrch: Switch Type: voq, Max ECMP Group Size supported: 512
NOTICE swss0#orchagent: :- RouteOrch: Set switch attribute ECMP member count to 128