Remove RIF from m_rifsToAdd before deleting it#3336
Merged
prsunny merged 14 commits intosonic-net:masterfrom Jan 30, 2025
Merged
Remove RIF from m_rifsToAdd before deleting it#3336prsunny merged 14 commits intosonic-net:masterfrom
prsunny merged 14 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@tshalvi , possible to add unit test? |
dgsudharsan
approved these changes
Nov 5, 2024
Collaborator
|
any further request or this can be merged? |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jan 6, 2025
|
|
||
| } No newline at end of file | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please remove unrelated changes from PR
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ayurkiv-nvda
pushed a commit
to ayurkiv-nvda/sonic-swss
that referenced
this pull request
Jan 22, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to 202411: #3499 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Remove RIF from m_rifsToAdd before deleting RIF What I did I extended the RIF removal functionality to also remove the port from the m_rifsToAdd list. Why I did it Typically, the counter and object handling logic follows a strict sequence: Create an object, then start counter polling. Stop counter polling, then remove the object. However, there is deferred logic for RIF counters, where counter polling starts based on a timer rather than immediately. This process generally works as follows: Create an object and add it to a list upon receiving an APP_DB update. Start counter polling for all objects in the list during the timer event. Stop counter polling for an object. Remove the object. If RIF creation and removal occur frequently, removal can happen before the timer event. As a result, the timer may start counter polling for an object that has just been removed, causing the following error message: ERR syncd#SDK: :- processFlexCounterEvent: port VID oid:0x600000000099d, was not found (probably port was removed/splitted) and will remove from counters now
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
* Remove RIF from m_rifsToAdd before deleting RIF What I did I extended the RIF removal functionality to also remove the port from the m_rifsToAdd list. Why I did it Typically, the counter and object handling logic follows a strict sequence: Create an object, then start counter polling. Stop counter polling, then remove the object. However, there is deferred logic for RIF counters, where counter polling starts based on a timer rather than immediately. This process generally works as follows: Create an object and add it to a list upon receiving an APP_DB update. Start counter polling for all objects in the list during the timer event. Stop counter polling for an object. Remove the object. If RIF creation and removal occur frequently, removal can happen before the timer event. As a result, the timer may start counter polling for an object that has just been removed, causing the following error message: ERR syncd#SDK: :- processFlexCounterEvent: port VID oid:0x600000000099d, was not found (probably port was removed/splitted) and will remove from counters now Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I extended the RIF removal functionality to also remove the port from the m_rifsToAdd list.
Why I did it
Typically, the counter and object handling logic follows a strict sequence:
Create an object, then start counter polling.
Stop counter polling, then remove the object.
However, there is deferred logic for RIF counters, where counter polling starts based on a timer rather than immediately.
This process generally works as follows:
If RIF creation and removal occur frequently, removal can happen before the timer event. As a result, the timer may start counter polling for an object that has just been removed, causing the following error message:
ERR syncd#SDK: :- processFlexCounterEvent: port VID oid:0x600000000099d, was not found (probably port was removed/splitted) and will remove from counters nowHow I verified it
Tested in regression.
Details if related