Skip to content

[portsorch]: Update comments#333

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:comment
Oct 4, 2017
Merged

[portsorch]: Update comments#333
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:comment

Conversation

@stcheng
Copy link
Copy Markdown
Contributor

@stcheng stcheng commented Oct 4, 2017

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng stcheng merged commit f208eb7 into sonic-net:master Oct 4, 2017
@stcheng stcheng deleted the comment branch October 4, 2017 04:15
stcheng pushed a commit to stcheng/sonic-swss that referenced this pull request Oct 5, 2017
praveen-li pushed a commit to praveen-li/sonic-swss that referenced this pull request Aug 24, 2020
* msft_github/master:
  [portsorch]: Use sai_serialize api to write to DB (sonic-net#331)
  [portsorch]: Update comments (sonic-net#333)
  [switchorch]: Add support of ECMP and LAG hash seed attribute (sonic-net#324)
  [portsorch]: Add support of cable breakout feature (sonic-net#320)
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
* Added argument forwarder for platform reboot.
* Removed code duplication.
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023
…d in the eepromTlvInfo decode (sonic-net#333)

Description
The VEMDOR_EXT field parse the data and format each in byte in hex with space as separator. But the logic leaves a space at the end of the value. This PR removes the trailing space in output of the VENDOR_EXT field in the eepromTlvInfo decode

This change is needed by 202205 branch

Motivation and Context
The trailing space at end of the VENDOR_EXT field cause the test of function get_system_eeprom_info() failed. The trailing space of the data filed is invisible char in the show platform syseeprom output while the get_system_eeprom_info() return a dictionary with trailing space in the end. This results in a mis-matched in the test case.

Signed-off-by: mlok <marty.lok@nokia.com>
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants