[202205][routeorch] Fixing bug with multiple routes pointing to nhg #3006
Merged
prsunny merged 5 commits intosonic-net:202205from Jan 8, 2024
Merged
[202205][routeorch] Fixing bug with multiple routes pointing to nhg #3006prsunny merged 5 commits intosonic-net:202205from
prsunny merged 5 commits intosonic-net:202205from
Conversation
- Refactored multi_mux_nexthops tests and added new test cases. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
test_drop_counters.py::TestDropCounters::test_add_remove_port test_drop_counters.py::TestDropCounters::test_createAndDeleteMultipleCounters Above test cases are failing and causing PRs to fail Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jan 8, 2024
Collaborator
|
Test failed due to known issue. Master and 202305 PRs passed. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed a bug where multiple routes pointing to the same nhg would not remove the route from m_nextHops cache in routeorch
Refactored multi_mux_nexthops tests and added new test cases
Why I did it
Caught the bug while refactoring, this will cause issues with switchover if one of the routes is removed
How I verified it
Ran refactored tests on local vstest setup, and all test cases passed
Details if related
cherry-pick of #2999