[action] [PR:2948] Fix maximum headroom check failure (#2948)#3001
Closed
mssonicbld wants to merge 1 commit intosonic-net:202205from
Closed
[action] [PR:2948] Fix maximum headroom check failure (#2948)#3001mssonicbld wants to merge 1 commit intosonic-net:202205from
mssonicbld wants to merge 1 commit intosonic-net:202205from
Conversation
The accumulative headroom on a port is compared with the maximum headroom supported on the port whenever a buffer priority group is created/updated. This depends on the maximum headroom being exposed to the STATE_DB during orchagent initialization. However, in the cold reboot, orchagent starts slow which prevents the threshold from being exposed on time. In this case, the buffer manager is not able to perform the headroom check and the buffer orchagent should handle the possible failure from SAI in case the accumulative headroom exceeds the threshold.
Collaborator
Author
|
Original PR: #2948 |
Collaborator
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Failed to download some deb packages |
Collaborator
|
No longer need to cherry-pick. Closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accumulative headroom on a port is compared with the maximum headroom supported on the port
whenever a buffer priority group is created/updated.
This depends on the maximum headroom being exposed to the STATE_DB during orchagent initialization.
However, in the cold reboot, orchagent starts slow which prevents the threshold from being exposed on time.
In this case, the buffer manager is not able to perform the headroom check
and the buffer orchagent should handle the possible failure from SAI in case the accumulative headroom exceeds the threshold.