[hash]: Add ECMP/LAG hash algorithm to OA#2953
Merged
prsunny merged 2 commits intosonic-net:masterfrom Nov 30, 2023
Merged
Conversation
Collaborator
Author
|
@stepanblyschak FYI |
nazariig
force-pushed
the
master-hash-algorithm
branch
from
c398098 to
e8cf4e3
Compare
stepanblyschak
approved these changes
Nov 3, 2023
nazariig
force-pushed
the
master-hash-algorithm
branch
from
e8cf4e3 to
3f25526
Compare
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-hash-algorithm
branch
from
3f25526 to
15961a0
Compare
Collaborator
|
@prsunny kindly reminder to review or to assign someone on behalf of you. |
nazariig
force-pushed
the
master-hash-algorithm
branch
from
15961a0 to
abaf3fb
Compare
Collaborator
Author
|
@prsunny just a kind reminder |
nazariig
force-pushed
the
master-hash-algorithm
branch
2 times, most recently
from
5265fe8 to
473135a
Compare
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-hash-algorithm
branch
from
473135a to
e7a3692
Compare
Collaborator
Author
|
@prsunny just a kind reminder |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@prsunny just a kind reminder |
nazariig
force-pushed
the
master-hash-algorithm
branch
from
e7a3692 to
0fa0985
Compare
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
nazariig
force-pushed
the
master-hash-algorithm
branch
from
edc5663 to
5b83e97
Compare
Collaborator
Author
|
@prsunny just a kind reminder |
prsunny
approved these changes
Nov 30, 2023
|
|
||
| if (obj.haSet.empty()) | ||
| { | ||
| SWSS_LOG_ERROR("Failed to validate hash algorithm: no hash algorithm capabilities"); |
Collaborator
There was a problem hiding this comment.
this must be WARN instead of ERROR as some platforms may not support algorithm capabilities
|
|
||
| if (obj.haSet.count(haValue) == 0) | ||
| { | ||
| SWSS_LOG_ERROR("Failed to validate hash algorithm: value(%s) is not supported", toStr(haValue).c_str()); |
Collaborator
There was a problem hiding this comment.
Same here. Please change to WARN
Contributor
|
Already in 202311. |
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [hash]: Add ECMP/LAG hash algorithm to OA. * Implement as defined in sonic-net/SONiC#1501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
DEPENDS:
HLD: sonic-net/SONiC#1501
What I did
Why I did it
How I verified it
Details if related