Reducing the severity of oper fec attribute get failure#2924
Merged
prsunny merged 3 commits intosonic-net:masterfrom Oct 13, 2023
Merged
Reducing the severity of oper fec attribute get failure#2924prsunny merged 3 commits intosonic-net:masterfrom
prsunny merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Oct 12, 2023
prgeor
approved these changes
Oct 12, 2023
Contributor
|
@dgsudharsan do we need in 202305? if so please add the branch tag |
Collaborator
Author
Not required as the feature is only present in master. |
prsunny
approved these changes
Oct 13, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Reduced the severity of log when get attribute of oper fec failed. Why I did it The oper fec is not a mandatory attribute and may not be implemented by vendor SAI, in which case throwing an error is wrong. Reduced the severity of the log message to notice. This will also fix the checker issues in sonic-net/sonic-buildimage#16785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Reduced the severity of log when get attribute of oper fec failed.
Why I did it
The oper fec is not a mandatory attribute and may not be implemented by vendor SAI, in which case throwing an error is wrong. Reduced the severity of the log message to notice. This will also fix the checker issues in sonic-net/sonic-buildimage#16785
How I verified it
Details if related