[DASH] ACL tags implementation

[oleksandrivantsiv]

What I did
Implement the DASH ACL tags feature according to DASH ACL tags HLD

Why I did it
To add support for DASH ACL tags feature

How I verified it
Run extended VS tests that cover new implementation

Details if related

[oleksandrivantsiv]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[oleksandrivantsiv]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[oleksandrivantsiv]

@prsunny kindly reminder.
Can you please review or assign someone to review the PR?

[Pterosaur]

All changes look good to me.

@prsunny , But there is a concern that we store FULL ACL cache(groups, rules, and tags) in the memory of orchagent. Do you have any suggestions about this?

[prsunny]

All changes look good to me.

@prsunny , But there is a concern that we store FULL ACL cache(groups, rules, and tags) in the memory of orchagent. Do you have any suggestions about this?

thats a good catch. We don't want to have cache for ACL rules, otherwise it will take high memory. @oleksandrivantsiv , could you please check on this and remove cache.

[oleksandrivantsiv]

All changes look good to me.
@prsunny , But there is a concern that we store FULL ACL cache(groups, rules, and tags) in the memory of orchagent. Do you have any suggestions about this?

thats a good catch. We don't want to have cache for ACL rules, otherwise it will take high memory. @oleksandrivantsiv , could you please check on this and remove cache.

@prsunny I have a plan to remove a cache in the separate PR by querying the information from APP DB directly. I suggest merging this PR to allow us to start working on the "E2E" flow testing.

[Pterosaur]

All changes look good to me.
@prsunny , But there is a concern that we store FULL ACL cache(groups, rules, and tags) in the memory of orchagent. Do you have any suggestions about this?

thats a good catch. We don't want to have cache for ACL rules, otherwise it will take high memory. @oleksandrivantsiv , could you please check on this and remove cache.

@prsunny I have a plan to remove a cache in the separate PR by querying the information from APP DB directly. I suggest merging this PR to allow us to start working on the "E2E" flow testing.

@oleksandrivantsiv Agree. Could you please update a commit: 966c5bb that is for fixing an ACL bug?

[oleksandrivantsiv]

All changes look good to me.
@prsunny , But there is a concern that we store FULL ACL cache(groups, rules, and tags) in the memory of orchagent. Do you have any suggestions about this?

thats a good catch. We don't want to have cache for ACL rules, otherwise it will take high memory. @oleksandrivantsiv , could you please check on this and remove cache.

@prsunny I have a plan to remove a cache in the separate PR by querying the information from APP DB directly. I suggest merging this PR to allow us to start working on the "E2E" flow testing.

@oleksandrivantsiv Agree. Could you please update a commit: 966c5bb that is for fixing an ACL bug?

@Pterosaur I updated the branch to include the changes form 966c5bb commit.

[oleksandrivantsiv]

@prsunny, @Pterosaur if there are no other comments can you please approve the PR?

[oleksandrivantsiv]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).