Skip to content

Fix port speed validation #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
Aug 22, 2017
Merged

Fix port speed validation #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions orchagent/portsorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,22 @@ bool PortsOrch::validatePortSpeed(sai_object_id_t port_id, sai_uint32_t speed)
}
else
{
SWSS_LOG_ERROR("Failed to get supported speed list for port %lx\n", port_id);
SWSS_LOG_ERROR("Failed to get supported speed list for port %lx", port_id);
return false;
}
}
// TODO: change to macro SAI_STATUS_IS_ATTR_NOT_SUPPORTED once it is fixed in SAI
// https://github.com/opencomputeproject/SAI/pull/710
else if (((status) & (~0xFFFF)) == SAI_STATUS_ATTR_NOT_SUPPORTED_0)
{
// unable to validate speed if attribute is not supported on platform
// assuming input value is correct
SWSS_LOG_WARN("Unable to validate speed for port %lx. Not supported by platform", port_id);
return true;
}
else
{
SWSS_LOG_ERROR("Failed to get number of supported speeds for port %lx\n", port_id);
SWSS_LOG_ERROR("Failed to get number of supported speeds for port %lx", port_id);
return false;
}
}
Expand Down