Support WRED profiles on system ports #2851
Closed
vmittal-msft wants to merge 2 commits intomasterfrom
Closed
Conversation
Contributor
Author
vmittal-msft
requested review from
arlakshm,
gechiang,
kenneth-arista and
neethajohn
and removed request for
neethajohn
Contributor
Author
|
@kenneth-arista @cheryls-arista please review. |
| } | ||
| } | ||
| else | ||
| { |
Contributor
There was a problem hiding this comment.
Looks like the difference here is the param passed to isPortAdminUp. Can you change it to the following?
auto &tmp_port_name = local_port ? local_port_name : port_name;
if (gPortsOrch->isPortAdminUp(tmp_port_name)) {
SWSS_LOG_WARN("Queue profile '%s' applied after port %s is up", key.c_str(), port_name.c_str());
}
Contributor
|
portsorch.cpp change looks fine. I don't have enough background to review the other changes. |
Contributor
Author
|
Opened following PR to take care of this issue - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added support to apply wred profile on system ports
Why I did it
remote system ports were missing wred profile
How I verified it
Tested on sonic chassis
Details if related