Allow NOT_IMPLEMENTED sai return status for availability monitoring API#2848
Merged
tjchadaga merged 1 commit intosonic-net:masterfrom Jul 7, 2023
Merged
Conversation
Contributor
Author
|
@saksarav-nokia - please help review as well |
saksarav-nokia
approved these changes
Jul 5, 2023
prsunny
approved these changes
Jul 7, 2023
yxieca
pushed a commit
that referenced
this pull request
Jul 7, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 19, 2023
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added SAI_STATUS_NOT_IMPLEMENTED to SAI return status check while fetching resource availability.
Why I did it
If resource availability lookup API is not supported for a specific object, the API returns SAI_STATUS_NOT_IMPLEMENTED or SAI_STATUS_NOT_SUPPORTED. These return values do not indicate unavailability of the resource itself and need to be ignored.
How I verified it
Everflow tests on 202205 with SAI which returns SAI_STATUS_NOT_IMPLEMENTED
Details if related
MSFT ADO: 24482256