[QoS] Enhance QosOrch::doTask by handling QUEUE table after all the rest tables handled to avoid retry#2801
Merged
neethajohn merged 1 commit intosonic-net:masterfrom May 30, 2023
Conversation
…bles handled Signed-off-by: Stephen Sun <stephens@nvidia.com>
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
May 30, 2023
neethajohn
approved these changes
May 30, 2023
stephenxs
added a commit
to Junchao-Mellanox/sonic-swss
that referenced
this pull request
Jun 6, 2023
…bles handled (sonic-net#2801) Signed-off-by: Stephen Sun <stephens@nvidia.com> What I did Enhance QosOrch::doTask by handling QUEUE table after all the rest tables handled to avoid retry Signed-off-by: Stephen Sun stephens@nvidia.com Details if related During system initialization, QoS table items are received before gPortsOrch->allPortsReady() becomes true and will be handled all together after it becomes true. In most cases, it will be handled in the for loop in the following snippet of code in OrchDaemon::start() auto *c = (Executor *)s; c->execute(); /* After each iteration, periodically check all m_toSync map to * execute all the remaining tasks that need to be retried. */ /* TODO: Abstract Orch class to have a specific todo list */ for (Orch *o : m_orchList) o->doTask(); The QUEUE table items reference WRED_PROFILE and SCHEDULER_PROFILE table items. In case the latter tables are handled after the QUEUE table, the QUEUE table needs to be retried in the next for loop, which is not necessary. So, we adjust the order in which the tables are handled to guarantee that all QoS table items to be handled in a single call to QosOrch::doTask.
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 10, 2023
…bles handled (#2801) Signed-off-by: Stephen Sun <stephens@nvidia.com> What I did Enhance QosOrch::doTask by handling QUEUE table after all the rest tables handled to avoid retry Signed-off-by: Stephen Sun stephens@nvidia.com Details if related During system initialization, QoS table items are received before gPortsOrch->allPortsReady() becomes true and will be handled all together after it becomes true. In most cases, it will be handled in the for loop in the following snippet of code in OrchDaemon::start() auto *c = (Executor *)s; c->execute(); /* After each iteration, periodically check all m_toSync map to * execute all the remaining tasks that need to be retried. */ /* TODO: Abstract Orch class to have a specific todo list */ for (Orch *o : m_orchList) o->doTask(); The QUEUE table items reference WRED_PROFILE and SCHEDULER_PROFILE table items. In case the latter tables are handled after the QUEUE table, the QUEUE table needs to be retried in the next for loop, which is not necessary. So, we adjust the order in which the tables are handled to guarantee that all QoS table items to be handled in a single call to QosOrch::doTask.
Collaborator
Author
|
Added |
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
…bles handled (sonic-net#2801) Signed-off-by: Stephen Sun <stephens@nvidia.com> What I did Enhance QosOrch::doTask by handling QUEUE table after all the rest tables handled to avoid retry Signed-off-by: Stephen Sun stephens@nvidia.com Details if related During system initialization, QoS table items are received before gPortsOrch->allPortsReady() becomes true and will be handled all together after it becomes true. In most cases, it will be handled in the for loop in the following snippet of code in OrchDaemon::start() auto *c = (Executor *)s; c->execute(); /* After each iteration, periodically check all m_toSync map to * execute all the remaining tasks that need to be retried. */ /* TODO: Abstract Orch class to have a specific todo list */ for (Orch *o : m_orchList) o->doTask(); The QUEUE table items reference WRED_PROFILE and SCHEDULER_PROFILE table items. In case the latter tables are handled after the QUEUE table, the QUEUE table needs to be retried in the next for loop, which is not necessary. So, we adjust the order in which the tables are handled to guarantee that all QoS table items to be handled in a single call to QosOrch::doTask.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…bles handled (sonic-net#2801) Signed-off-by: Stephen Sun <stephens@nvidia.com> What I did Enhance QosOrch::doTask by handling QUEUE table after all the rest tables handled to avoid retry Signed-off-by: Stephen Sun stephens@nvidia.com Details if related During system initialization, QoS table items are received before gPortsOrch->allPortsReady() becomes true and will be handled all together after it becomes true. In most cases, it will be handled in the for loop in the following snippet of code in OrchDaemon::start() auto *c = (Executor *)s; c->execute(); /* After each iteration, periodically check all m_toSync map to * execute all the remaining tasks that need to be retried. */ /* TODO: Abstract Orch class to have a specific todo list */ for (Orch *o : m_orchList) o->doTask(); The QUEUE table items reference WRED_PROFILE and SCHEDULER_PROFILE table items. In case the latter tables are handled after the QUEUE table, the QUEUE table needs to be retried in the next for loop, which is not necessary. So, we adjust the order in which the tables are handled to guarantee that all QoS table items to be handled in a single call to QosOrch::doTask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Enhance
QosOrch::doTaskby handling QUEUE table after all the rest tables handled to avoid retrySigned-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I verified it
Details if related
During system initialization, QoS table items are received before
gPortsOrch->allPortsReady()becomes true and will be handled all together after it becomes true.In most cases, it will be handled in the for loop in the following snippet of code in
OrchDaemon::start()The
QUEUEtable items referenceWRED_PROFILEandSCHEDULER_PROFILEtable items. In case the latter tables are handled after theQUEUEtable, theQUEUEtable needs to be retried in the next for loop, which is not necessary.So, we adjust the order in which the tables are handled to guarantee that all QoS table items to be handled in a single call to
QosOrch::doTask.