Skip to content

[ASAN]Increasing switch create timeout for ASAN images #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 5 commits into from
May 30, 2023
Merged

[ASAN]Increasing switch create timeout for ASAN images #2777

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02fff2a
[ASAN]Increasing switch create timeout for ASAN images
dgsudharsan May 12, 2023
6910957
Addressing review comment
dgsudharsan May 12, 2023
5881ccc
Adding back new line
dgsudharsan May 12, 2023
1c56866
Refactoring code
dgsudharsan May 12, 2023
cb72e56
Removing ifdef and reading if asan is enabled from env options
dgsudharsan May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion orchagent/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,16 @@ int main(int argc, char **argv)
attr.value.u64 = gSwitchId;
attrs.push_back(attr);

if (gMySwitchType == "voq" || gMySwitchType == "fabric" || gMySwitchType == "chassis-packet")
auto delay_factor = 1;
bool asan_enabled = false;

if (getenv("ASAN_OPTIONS"))
{
asan_enabled = true;
delay_factor = 2;
}

if (gMySwitchType == "voq" || gMySwitchType == "fabric" || gMySwitchType == "chassis-packet" || asan_enabled)
{
/* We set this long timeout in order for orchagent to wait enough time for
* response from syncd. It is needed since switch create takes more time
Expand All @@ -601,7 +610,12 @@ int main(int argc, char **argv)
{
attr.value.u64 = (10 * SAI_REDIS_DEFAULT_SYNC_OPERATION_RESPONSE_TIMEOUT);
}
else
{
attr.value.u64 = SAI_REDIS_DEFAULT_SYNC_OPERATION_RESPONSE_TIMEOUT;
}

attr.value.u64 = attr.value.u64*delay_factor;
attr.id = SAI_REDIS_SWITCH_ATTR_SYNC_OPERATION_RESPONSE_TIMEOUT;
status = sai_switch_api->set_switch_attribute(gSwitchId, &attr);

Expand Down