[202205] [flowcounterrouter] Fix the Route remove flow for non-bound prefixes by vivekrnv · Pull Request #2701 · sonic-net/sonic-swss

vivekrnv · 2023-03-14T17:06:44Z

What I did

Backport #2691 to 202205

Why I did it

How I verified it

Details if related

Signed-off-by: Vivek Reddy Karri <[email protected]>

vivekrnv · 2023-03-14T17:59:07Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-03-14T17:59:09Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-03-14T17:59:18Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2023-03-14T22:05:27Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-03-14T22:05:29Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-03-14T22:05:40Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2023-03-15T02:18:27Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-03-15T02:18:29Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-03-15T02:18:39Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2023-03-15T17:14:08Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-03-15T17:14:10Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-03-15T17:14:21Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2023-03-15T22:02:37Z

vtest failures:

Doesn't seem to be related to my changes. Seems this appeared in #2360 (comment) and seemingly fixed by #2350. We might need to cherry-pick #2350 to 2205

Test failures: https://dev.azure.com/mssonic/be1b070f-be15-4154-aade-b1d3bfb17054/_apis/build/builds/234198/logs/83

2023-03-15T21:32:58.7799524Z test_AclRuleAddWithoutTableDefinitionFails failed (1 runs remaining out of 2).
2023-03-15T21:32:58.7800476Z 	<class 'ValueError'>
2023-03-15T21:32:58.7801016Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7806344Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7809808Z test_AclRuleAddWithoutTableDefinitionFails failed; it passed 0 out of the required 1 times.
2023-03-15T21:32:58.7810801Z 	<class 'ValueError'>
2023-03-15T21:32:58.7811321Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7815671Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7819133Z test_MirrorSessionAddModifyAndDelete failed (1 runs remaining out of 2).
2023-03-15T21:32:58.7819871Z 	<class 'ValueError'>
2023-03-15T21:32:58.7820438Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7825141Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7828300Z test_MirrorSessionAddModifyAndDelete failed; it passed 0 out of the required 1 times.
2023-03-15T21:32:58.7829227Z 	<class 'ValueError'>
2023-03-15T21:32:58.7829871Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7835567Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1775>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:406>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7839329Z 
2023-03-15T21:32:58.7839895Z ===End Flaky Test Report===

liat-grozovik · 2023-03-16T10:53:45Z

@yxieca could you please check the possibility to cherry pick #2350 to 202205 to unblock this PR from getting in 202205?

dgsudharsan · 2023-03-16T16:06:57Z

@liat-grozovik This is already cherry-picked into 202205. So Closing this PR

[flowcounterrouter] Fix the Route remove flow for non-bound prefixes

5b5d499

Signed-off-by: Vivek Reddy Karri <[email protected]>

vivekrnv requested a review from prsunny as a code owner March 14, 2023 17:06

vivekrnv requested a review from Junchao-Mellanox March 14, 2023 17:58

Junchao-Mellanox approved these changes Mar 15, 2023

View reviewed changes

dgsudharsan closed this Mar 16, 2023

Conversation

vivekrnv commented Mar 14, 2023

Uh oh!

vivekrnv commented Mar 14, 2023

Uh oh!

mssonicbld commented Mar 14, 2023

Uh oh!

azure-pipelines bot commented Mar 14, 2023

Uh oh!

vivekrnv commented Mar 14, 2023

Uh oh!

mssonicbld commented Mar 14, 2023

Uh oh!

azure-pipelines bot commented Mar 14, 2023

Uh oh!

vivekrnv commented Mar 15, 2023

Uh oh!

mssonicbld commented Mar 15, 2023

Uh oh!

azure-pipelines bot commented Mar 15, 2023

Uh oh!

vivekrnv commented Mar 15, 2023

Uh oh!

mssonicbld commented Mar 15, 2023

Uh oh!

azure-pipelines bot commented Mar 15, 2023

Uh oh!

vivekrnv commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liat-grozovik commented Mar 16, 2023

Uh oh!

dgsudharsan commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vivekrnv commented Mar 15, 2023 •

edited

Loading