Skip to content

[202205] Modify coppmgr mergeConfig to support preserving copp tables through reboot#2592

Closed
dprital wants to merge 1 commit intosonic-net:202205from
dprital:preserve_copp_tables_202205
Closed

[202205] Modify coppmgr mergeConfig to support preserving copp tables through reboot#2592
dprital wants to merge 1 commit intosonic-net:202205from
dprital:preserve_copp_tables_202205

Conversation

@dprital
Copy link
Copy Markdown
Collaborator

@dprital dprital commented Dec 29, 2022

This PR implements [fastboot] Preserve CoPP table HLD to improve fastboot flow (sonic-net/SONiC#1107).

It is PR against 202205 of the following PR: #2548
Should go together with PR: sonic-net/sonic-utilities#2574

What I did

Modified coppmgr mergeConfig logic to support preserving copp tables contents through reboot. Handle duplicates, overwrites, unsupported keys preserved and new keys. According to sonic-net/SONiC#1107

Why I did it

To shorten dataplane downtime on fast-reboot

How I verified it

Manual tests (community fast-reboot test)

Details if related

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 29, 2022

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 29, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 29, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital dprital requested a review from dgsudharsan December 29, 2022 20:42
@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 29, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 30, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 30, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Dec 31, 2022

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Jan 1, 2023

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Jan 2, 2023

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Jan 2, 2023

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Jan 3, 2023

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Copy Markdown
Collaborator Author

dprital commented Jan 3, 2023

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

cherry pick was done. no need for this one

@dprital dprital deleted the preserve_copp_tables_202205 branch March 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants