Fixed set mtu for deleted subintf due to late notification#2571
Merged
prsunny merged 3 commits intosonic-net:masterfrom Dec 28, 2022
Merged
Conversation
dprital
previously approved these changes
Dec 14, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2571 in repo sonic-net/sonic-swss |
Contributor
Author
|
/azpw run Asure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Asure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
requested changes
Dec 19, 2022
| int ret = swss::exec(cmd_str, res); | ||
|
|
||
| return subifMtu; | ||
| if (ret && !isIntfStateOk(alias)) |
Collaborator
There was a problem hiding this comment.
This is already checked in the doIntfGeneralTask under SET operation. So why check again here? is there a race condition?
Contributor
Author
There was a problem hiding this comment.
We are not visiting the "doIntfGeneralTask" function in this flow.
The flow is:
- changing the "mtu" field in the PORT_TABLE in state DB
doTaskdoPortTableTaskupdateSubIntfMtusetHostSubIntfMtu
Collaborator
There was a problem hiding this comment.
ok, does this happen in the updateSubIntfAdminStatus flow as well? Or why only mtu change is handled?
Contributor
Author
There was a problem hiding this comment.
It is happen in the updateSubIntfAdminStatus flow as well
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Asure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Asure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@prsunny - Can you please approve this PR ? |
dprital
approved these changes
Dec 26, 2022
prsunny
approved these changes
Dec 28, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jan 1, 2023
Update sonic-swss submodule pointer to include the following: * bdedf69 Modify coppmgr mergeConfig to support preserving copp tables through reboot. ([sonic-net#2548](sonic-net/sonic-swss#2548)) * 7891e78 Fixed set mtu for deleted subintf due to late notification ([sonic-net#2571](sonic-net/sonic-swss#2571)) * a443945 Updated handling of VRF_VNI mapping and VLAN_VNI mapping for same VNI ID ([sonic-net#2538](sonic-net/sonic-swss#2538)) Signed-off-by: dprital <[email protected]>
8 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 2, 2023
Update sonic-swss submodule pointer to include the following: * bdedf69 Modify coppmgr mergeConfig to support preserving copp tables through reboot. ([#2548](sonic-net/sonic-swss#2548)) * 7891e78 Fixed set mtu for deleted subintf due to late notification ([#2571](sonic-net/sonic-swss#2571)) * a443945 Updated handling of VRF_VNI mapping and VLAN_VNI mapping for same VNI ID ([#2538](sonic-net/sonic-swss#2538)) Signed-off-by: dprital <[email protected]>
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 3, 2023
…2595) PR against 202205 based on the following PR: #2571 - What I did Ignores errors on the set MTU command for subinterface when the subinterface state is not OK. - Why I did it A race condition between the portmgrd and the intfmgrd sometimes causes running a set MTU command on a deleted subinterface. The logs and the error: INFO swss#supervisord: intfmgrd Cannot find device "Ethernet32.58" ERR swss#intfmgrd: :- main: Runtime error: /sbin/ip link set "Ethernet32.58" mtu "9100" : INFO swss#supervisord 2022-11-08 05:53:33,057 INFO exited: intfmgrd (exit status 255; not expected) - How I verified it Run the test_loopback_action_reload test and saw no errors in the logs.
StormLiangMS
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Fixed set mtu for deleted subintf due to late notification
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…#2571) * Fixed set mtu for deleted subintf due to late notification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Ignores errors on the set MTU command for subinterface when the subinterface state is not OK.
Why I did it
A race condition between the portmgrd and the intfmgrd sometimes causes running a set MTU command on a deleted subinterface.
The logs and the error:
How I verified it
Run the test_loopback_action_reload test and saw no errors in the logs.
Details if related