Merged
Conversation
The signature of `wait_for_n_keys` is:
def wait_for_n_keys(
self,
table_name,
num_keys,
wait_at_least_n_keys,
polling_config = PollingConfig(),
failure_message = None,
):
In the following methods:
DVSVlan.get_and_verify_vlan_ids
DVSVlan.get_and_verify_vlan_hostif_ids
They pass polling_config as the third argument, stored as parameter
wait_at_least_n_keys. This will cause trouble in the vlan or vlan
interface removal, wait_for_n_keys will return early as there are always
more than expected keys existing in the table. This will fail the next
testcase sometimes.
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Contributor
Author
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@lolyu can you look into the vstest failure? |
theasianpianist
approved these changes
Dec 8, 2022
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 9, 2022
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 9, 2022
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 10, 2022
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 10, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 18, 2022
Updated swss with latest from master temp check in review feedback Commented out test for chassis fix for compilation issue Fixed test failure feedback comments fix for processQ fix for processQ fix for processQ mock test update test_vlan.py fix skipping failing test for virtual chassis disable test_PortAutoNegWarm test minor fix disabling virtual chassis tests for now temp check in unskip failing test unkipped sonic-net#2 test fix minor errors temporarily disable test as PR sonic-net#2541 is having the fix
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Dec 20, 2022
Updated swss with latest from master temp check in review feedback Commented out test for chassis fix for compilation issue Fixed test failure feedback comments fix for processQ fix for processQ fix for processQ mock test update test_vlan.py fix skipping failing test for virtual chassis disable test_PortAutoNegWarm test minor fix disabling virtual chassis tests for now temp check in unskip failing test unkipped sonic-net#2 test fix minor errors temporarily disable test as PR sonic-net#2541 is having the fix
yxieca
pushed a commit
that referenced
this pull request
Jan 4, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
[VS] Fix Vlan test for the signature of wait_for_n_keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The signature of
wait_for_n_keysis:In the following methods:
DVSVlan.get_and_verify_vlan_idsDVSVlan.get_and_verify_vlan_hostif_idsThey pass
polling_configas the third argument, stored in the parameterwait_at_least_n_keysand always evaluated toTrue. This will cause trouble in the vlan or vlan interface removal,wait_for_n_keyswill always return early as there are always more than expected keys existing in the table. So when next testcase starts, those keys might still exist in the table and fail the next testcase.Signed-off-by: Longxiang Lyu lolv@microsoft.com
Why I did it
Stabilize
test_vlan.pyHow I verified it
Details if related