[azp]: Add Azp for DASH by Pterosaur · Pull Request #2501 · sonic-net/sonic-swss

Pterosaur · 2022-10-28T02:19:24Z

Signed-off-by: Ze Gan [email protected]

What I did

Add Azp job for DASH.

Why I did it

DASH needs CLI.

How I verified it

Check Azp.

Details if related

Signed-off-by: Ze Gan <[email protected]>

Pterosaur · 2022-10-28T02:33:23Z

/azp run

azure-pipelines · 2022-10-28T02:33:31Z

Azure Pipelines successfully started running 1 pipeline(s).

theasianpianist · 2022-10-28T20:11:25Z

.azure-pipelines/build-template.yml

      runVersion: 'latestFromBranch'
      runBranch: 'refs/heads/$(BUILD_BRANCH)'
-      path: $(Build.ArtifactStagingDirectory)/download
+      allowFailedBuilds: ${{ parameters.allow_failed_artifact }}


Why do we need to allow failed builds here?

The default value for allow_failed_artifact is false. So perhaps that is ok?

Looks like it's set to True in azure-pipeline-dash.yml below

Because we are using the branch, dash, of sonic-swss-common which also leverage the sairedis code in Azp: https://dev.azure.com/mssonic/build/_build/results?buildId=166787&view=logs&jobId=61b7eb0d-78fa-5af5-6df0-b6f82d3891a8&j=61b7eb0d-78fa-5af5-6df0-b6f82d3891a8&t=70f86778-6fb4-5097-2f4f-43a5d7a20e70 . But in the repo, sonic-sairedis, there is no related branch named 'dash'. So, there is failed in the sairedis building of sonic-swss-common. If allow_failed_artifact is false (by default), we cannot fetch an available artifact from sonic-swss-common.
I don't think we can directly use the master branch of sonic-swss-common, because other artifacts from DASH like 'syncd' and so on were using a specified commit of sonic-swss-common what was listed in the private sonic-buildimage.

As per #2501 (comment), we should be using the master branch of swss common. In this case, I don't think we still need to allow failed builds.

theasianpianist · 2022-10-28T20:14:11Z

/Azp run

azure-pipelines · 2022-10-28T20:14:17Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines-dash.yml

theasianpianist · 2022-10-28T20:41:14Z

.azure-pipelines/build-template.yml

@@ -84,38 +116,39 @@ jobs:
      artifact: ${{ parameters.swss_common_artifact_name }}
      runVersion: 'latestFromBranch'
      runBranch: 'refs/heads/$(BUILD_BRANCH)'


Looks like the swsscommon dash branch doesn't differ from the master branch - will this change in the future? Should we continue to use master branch here since the swsscommon job keeps failing due to the sairedis repo not having a dash branch?

My understanding is that swsscommon for dash will always be on master branch. @prsunny to confirm.

Discussed with @prsunny and @prabhataravind, we should always be using the master branch of swsscommon - can you add a new parameter like swss_common_branch_name so we can specify this for DASh jobs?

Signed-off-by: Ze Gan <[email protected]>

Pterosaur · 2022-11-05T13:57:47Z

/Azp run

azure-pipelines · 2022-11-05T13:57:57Z

Azure Pipelines successfully started running 2 pipeline(s).

Signed-off-by: Ze Gan <[email protected]>

theasianpianist · 2022-11-10T02:06:05Z

azure-pipelines-dash.yml

+      arch: amd64
+      sonic_slave: sonic-slave-buster
+      swss_common_artifact_name: sonic-swss-common
+      swss_common_branch: dash


Please change to master branch as per #2501 (comment)

azure-pipelines-dash.yml

theasianpianist · 2022-11-10T02:06:35Z

azure-pipelines-dash.yml

+      log_artifact_name: log
+      gcov_artifact_name: sonic-gcov
+      sonic_slave: sonic-slave-buster
+      swss_common_branch: dash


Please change to master branch as per #2501 (comment)

theasianpianist · 2022-11-10T02:07:21Z

.azure-pipelines/build-template.yml

      runVersion: 'latestFromBranch'
      runBranch: 'refs/heads/$(BUILD_BRANCH)'
-      path: $(Build.ArtifactStagingDirectory)/download
+      allowFailedBuilds: ${{ parameters.allow_failed_artifact }}


As per #2501 (comment), we should be using the master branch of swss common. In this case, I don't think we still need to allow failed builds.

theasianpianist · 2022-11-10T02:08:21Z

.azure-pipelines/build-docker-sonic-vs-template.yml

      runVersion: 'latestFromBranch'
-      runBranch: 'refs/heads/$(BUILD_BRANCH)'
+      runBranch: 'refs/heads/${{ parameters.swss_common_branch }}'
+      allowFailedBuilds: ${{ parameters.allow_failed_artifact }}


Since we're using the master branch of swss common, please remove this

Signed-off-by: Ze Gan <[email protected]>

theasianpianist

thanks!

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

Add Azp support

4021726

Signed-off-by: Ze Gan <[email protected]>

Pterosaur force-pushed the dash_azp branch from 7eca7f3 to 4021726 Compare October 28, 2022 02:20

Pterosaur marked this pull request as ready for review October 28, 2022 02:56

Pterosaur requested a review from prsunny as a code owner October 28, 2022 02:56

theasianpianist reviewed Oct 28, 2022

View reviewed changes

azure-pipelines-dash.yml Show resolved Hide resolved

theasianpianist reviewed Oct 28, 2022

View reviewed changes

Pterosaur added 2 commits November 5, 2022 02:36

Add swss common branch

adcd325

Signed-off-by: Ze Gan <[email protected]>

Move dash.yml to azp.yml

e2651df

Signed-off-by: Ze Gan <[email protected]>

Pterosaur requested review from prabhataravind and theasianpianist November 5, 2022 13:58

Pterosaur force-pushed the dash_azp branch 4 times, most recently from a57e9f7 to 2fbd14a Compare November 7, 2022 03:27

Remove dash.yml

6d48335

Signed-off-by: Ze Gan <[email protected]>

Pterosaur force-pushed the dash_azp branch from 2fbd14a to 6d48335 Compare November 7, 2022 03:29

Pterosaur added 2 commits November 7, 2022 14:38

Fix

90b3b56

Signed-off-by: Ze Gan <[email protected]>

Revert dash.yml

b525ab8

Signed-off-by: Ze Gan <[email protected]>

theasianpianist requested changes Nov 10, 2022

View reviewed changes

Change swss-common branch from dash to master

c154203

Signed-off-by: Ze Gan <[email protected]>

Pterosaur force-pushed the dash_azp branch from 191913f to c154203 Compare November 10, 2022 05:25

Pterosaur requested a review from theasianpianist November 10, 2022 05:28

theasianpianist approved these changes Nov 10, 2022

View reviewed changes

Pterosaur merged commit 46c0ca8 into sonic-net:dash Nov 11, 2022

Pterosaur mentioned this pull request Nov 11, 2022

[dash]: ACL orchagent #2470

Merged

Pterosaur added a commit to Pterosaur/sonic-swss that referenced this pull request Dec 23, 2022

[Azp]: Add Azp for DASH (sonic-net#2501)

6da1467

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

Pterosaur added a commit to Pterosaur/sonic-swss that referenced this pull request Dec 23, 2022

[Azp]: Add Azp for DASH (sonic-net#2501)

ebd2f24

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 21, 2023

[Azp]: Add Azp for DASH (sonic-net#2501)

2fda16b

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 25, 2023

[Azp]: Add Azp for DASH (sonic-net#2501)

c369a2b

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025

(conflict)[Azp]: Add Azp for DASH (sonic-net#2501)

6470dc1

What I did Add Azp job for DASH. Why I did it DASH needs CLI. How I verified it Check Azp. Signed-off-by: Ze Gan <[email protected]>

Conversation

Pterosaur commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pterosaur commented Oct 28, 2022

Uh oh!

azure-pipelines bot commented Oct 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pterosaur Nov 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theasianpianist commented Oct 28, 2022

Uh oh!

azure-pipelines bot commented Oct 28, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pterosaur commented Nov 5, 2022

Uh oh!

azure-pipelines bot commented Nov 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theasianpianist left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pterosaur commented Oct 28, 2022 •

edited

Loading

Pterosaur Nov 5, 2022 •

edited

Loading