[build] add missing package libyang-dev in lgtm.yml#2475
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Oct 1, 2022
Merged
[build] add missing package libyang-dev in lgtm.yml#2475qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
prsunny
approved these changes
Sep 30, 2022
Contributor
Author
|
The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp |
yxieca
pushed a commit
that referenced
this pull request
Oct 3, 2022
**Why I did it** lgtm build process broken. This PR will fix it. ``` [2022-09-30 18:21:33] [build-stderr] In file included from defaultvalueprovider.cpp:10: [2022-09-30 18:21:33] [build-stderr] defaultvalueprovider.h:8:10: fatal error: libyang/libyang.h: No such file or directory [2022-09-30 18:21:33] [build-stderr] 8 | #include <libyang/libyang.h> [2022-09-30 18:21:33] [build-stderr] | ^~~~~~~~~~~~~~~~~~~ [2022-09-30 18:21:33] [build-stderr] compilation terminated. ``` **How I verified it** The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp
vadymhlushko-mlnx
pushed a commit
to vadymhlushko-mlnx/sonic-swss
that referenced
this pull request
Oct 10, 2022
**Why I did it** lgtm build process broken. This PR will fix it. ``` [2022-09-30 18:21:33] [build-stderr] In file included from defaultvalueprovider.cpp:10: [2022-09-30 18:21:33] [build-stderr] defaultvalueprovider.h:8:10: fatal error: libyang/libyang.h: No such file or directory [2022-09-30 18:21:33] [build-stderr] 8 | #include <libyang/libyang.h> [2022-09-30 18:21:33] [build-stderr] | ^~~~~~~~~~~~~~~~~~~ [2022-09-30 18:21:33] [build-stderr] compilation terminated. ``` **How I verified it** The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp
Pterosaur
pushed a commit
to Pterosaur/sonic-swss
that referenced
this pull request
Nov 5, 2022
**Why I did it** lgtm build process broken. This PR will fix it. ``` [2022-09-30 18:21:33] [build-stderr] In file included from defaultvalueprovider.cpp:10: [2022-09-30 18:21:33] [build-stderr] defaultvalueprovider.h:8:10: fatal error: libyang/libyang.h: No such file or directory [2022-09-30 18:21:33] [build-stderr] 8 | #include <libyang/libyang.h> [2022-09-30 18:21:33] [build-stderr] | ^~~~~~~~~~~~~~~~~~~ [2022-09-30 18:21:33] [build-stderr] compilation terminated. ``` **How I verified it** The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
**Why I did it** lgtm build process broken. This PR will fix it. ``` [2022-09-30 18:21:33] [build-stderr] In file included from defaultvalueprovider.cpp:10: [2022-09-30 18:21:33] [build-stderr] defaultvalueprovider.h:8:10: fatal error: libyang/libyang.h: No such file or directory [2022-09-30 18:21:33] [build-stderr] 8 | #include <libyang/libyang.h> [2022-09-30 18:21:33] [build-stderr] | ^~~~~~~~~~~~~~~~~~~ [2022-09-30 18:21:33] [build-stderr] compilation terminated. ``` **How I verified it** The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
lgtm build process broken. This PR will fix it.
How I verified it
The lgtm.yml change does not take effect in this PR's checker. I manually test it https://lgtm.com/logs/19f4015aec3863d7d4e7d5667cbbc251efd1d0f4/lang:cpp
Details if related