[orchagent] Fix issue: ip prefix shall be inited even if VRF/VNET is not ready#2461
Merged
prsunny merged 1 commit intosonic-net:masterfrom Sep 23, 2022
Merged
Conversation
Collaborator
|
@Junchao-Mellanox is it required for 202205 as well? if so, need to set label |
keboliu
approved these changes
Sep 22, 2022
Collaborator
Author
|
Hi @prsunny , could you please help review? |
prsunny
approved these changes
Sep 23, 2022
7 tasks
Collaborator
Author
|
Hi @yxieca , could you please help cherry-pick to 202205? Thanks |
yxieca
pushed a commit
that referenced
this pull request
Sep 26, 2022
…not ready (#2461) *Flexcounter - Fix issue: ip prefix of a route flow pattern shall be initialized even if VRF/VNET is not ready
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…not ready (sonic-net#2461) *Flexcounter - Fix issue: ip prefix of a route flow pattern shall be initialized even if VRF/VNET is not ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix issue: ip prefix of a route flow pattern shall be initialized even if VRF/VNET is not ready
Why I did it
The issue cause a crash:
How I verified it
Manual test and added new unit test.
Details if related
The flow in which IpPrefix had an uninitialized member, consists of:
FlowCounterRouteOrch::addRoutePattern() with 'Vnet1|100.1.1.1/32'
Vnet1 does not exist yet, but the logic of addRoutePattern ignores that, assuming default vrf was meant and due to the way parseRouteKeyForRoutePattern works IpPrefix is left unitialized
Vnet1 is created
Flow counters are enabled, generateRouteFlowStats() -> createRouteFlowCounterByPattern() -> createRouteFlowCounterFromVnetRoutes() is called
Because we inserted a route pattern with defalt vrf id and unititliazed IpPrefix it leads to a crash