[muxorch] return true if the nbr IP is in the skip_neighbors list#2407
Merged
yxieca merged 1 commit intosonic-net:masterfrom Aug 9, 2022
Merged
[muxorch] return true if the nbr IP is in the skip_neighbors list#2407yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Orchagent was not programming neighbor IP to h/w L3 host table during initialization because they were set as Standby. When the links became active, SoC IPs were added to the skip_neighbors_ list and never programmed. fix: - Added public method MuxCable::getSkipNeighborsSet() - check if nbr is in skip_neighbors_ when checking if cable is Active Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
|
|
prsunny
reviewed
Aug 4, 2022
Collaborator
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
Changes lgtm. Can you add a test as well?
lolyu
approved these changes
Aug 5, 2022
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@Ndancejic , are the test failures due to the change? |
Contributor
Author
|
/easycla |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/easycla |
yxieca
pushed a commit
that referenced
this pull request
Aug 9, 2022
) Orchagent was not programming neighbor IP to h/w L3 host table during initialization because they were set as Standby. When the links became active, SoC IPs were added to the skip_neighbors_ list and never programmed. fix: - Added public method MuxCable::getSkipNeighborsSet() - check if nbr is in skip_neighbors_ when checking if cable is Active Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com> Co-authored-by: Ubuntu <dancejic@dancejic-vm.tmcjvzftiwdebn3deov5sqribb.xx.internal.cloudapp.net>
Ndancejic
added a commit
to Ndancejic/sonic-swss
that referenced
this pull request
Aug 16, 2022
PR sonic-net#2407 added a check which returned true in isNeighborActive if it is in the skip_neighbors_ list, but only checked for Mux in Subnet. This extends that check to Mux Ports and Nexthop Muxes. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…nic-net#2407) Orchagent was not programming neighbor IP to h/w L3 host table during initialization because they were set as Standby. When the links became active, SoC IPs were added to the skip_neighbors_ list and never programmed. fix: - Added public method MuxCable::getSkipNeighborsSet() - check if nbr is in skip_neighbors_ when checking if cable is Active Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com> Co-authored-by: Ubuntu <dancejic@dancejic-vm.tmcjvzftiwdebn3deov5sqribb.xx.internal.cloudapp.net>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…() (sonic-net#2415) * [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() PR sonic-net#2407 added a check which returned true in isNeighborActive if it is in the skip_neighbors_ list, but only checked for Mux in Subnet. This extends that check to Mux Ports and Nexthop Muxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orchagent was not programming neighbor IP to h/w L3 host table during
initialization because they were set as Standby. When the links became
active, SoC IPs were added to the skip_neighbors_ list and never
programmed. fix:
Signed-off-by: Nikola Dancejic ndancejic@microsoft.com
related to: #2369