Skip to content

[EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow#2404

Merged
liat-grozovik merged 6 commits intosonic-net:masterfrom
dgsudharsan:evpn_vrf_map_fix
Aug 8, 2022
Merged

[EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow#2404
liat-grozovik merged 6 commits intosonic-net:masterfrom
dgsudharsan:evpn_vrf_map_fix

Conversation

@dgsudharsan
Copy link
Copy Markdown
Collaborator

Same as PR #2387

What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Modified the tunnel stats interval to 10 sec
Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported

Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.

How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later

Details if related

…map creation flow

During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map
…tunnel is not supported 2) Modified the tunnel counter polling interval to 10000 ms by default
@dgsudharsan dgsudharsan requested a review from prsunny as a code owner August 3, 2022 16:50
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Aug 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 3, 2022

This pull request fixes 1 alert when merging 86f3ec3 into 3161eaa - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@zhangyanzhao
Copy link
Copy Markdown

zhangyanzhao commented Aug 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@dgsudharsan
Copy link
Copy Markdown
Collaborator Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@dgsudharsan shoudl it be taken to otehr branches or master only?

@dgsudharsan
Copy link
Copy Markdown
Collaborator Author

@liat-grozovik Request for 202205.

@liat-grozovik liat-grozovik merged commit 168bd3b into sonic-net:master Aug 8, 2022
yxieca pushed a commit that referenced this pull request Aug 8, 2022
…map creation flow (#2404)

Same as PR #2387

- What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Modified the tunnel stats interval to 10 sec
Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported

- Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.

- How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later
@dgsudharsan dgsudharsan deleted the evpn_vrf_map_fix branch March 9, 2023 02:02
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Mar 31, 2023
…map creation flow (sonic-net#2404)

Same as PR sonic-net#2387

- What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Modified the tunnel stats interval to 10 sec
Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported

- Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.

- How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
…map creation flow (sonic-net#2404)

Same as PR sonic-net#2387

- What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Modified the tunnel stats interval to 10 sec
Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported

- Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.

- How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants