Skip to content

[portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it#2400

Merged
prgeor merged 2 commits intosonic-net:masterfrom
stephenxs:readd-supported-fecs
Aug 8, 2022
Merged

[portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it#2400
prgeor merged 2 commits intosonic-net:masterfrom
stephenxs:readd-supported-fecs

Conversation

@stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jul 27, 2022 •
edited
Loading

This is to

What I did
Expose supported FEC modes to STATE_DB.PORT_TABLE|<port>.supported_fecs.
The orchagent calls get_port_attribute to get attribute SAI_PORT_ATTR_SUPPORTED_FEC_MODE during initialization and then records it into internal data.

  • By default, the supported FEC modes will be returned by SAI and exposed to STATE_DB. Eg. rs,none means only rs and none is supported on the port.
    • The orchagent will check whether the FEC mode is supported on the port before calling the SAI API to set it.
    • The CLI will check whether the FEC mode is in supported_fecs before setting FEC mode on a port to the CONFIG_DB
  • In case the SAI API does not support any FEC mode on the port, N/A will be exposed to STATE_DB
    • The orchagent will deny any FEC setting and prints log.
    • The CLI will deny FEC setting.
  • In case the SAI API get_port_attribute returns Not implemented
    • No check will be performed before setting a FEC mode to SAI on the port.
    • The CLI will check whether the FEC mode is defined before setting it to CONFIG_DB.

Why I did it
It is not supported to set FEC mode on some platforms. To avoid error, we need to expose the supported FEC list.

How I verified it
Manually test and mock test.

Details if related

@stephenxs stephenxs requested a review from prgeor July 27, 2022 01:45
@stephenxs stephenxs mentioned this pull request Jul 27, 2022
Merged
@stephenxs stephenxs marked this pull request as ready for review July 27, 2022 08:02
@stephenxs stephenxs requested a review from prsunny as a code owner July 27, 2022 08:02
@stephenxs
Copy link
Collaborator Author

stephenxs commented Jul 27, 2022

@prsunny @prgeor
can you approve and merge this PR? It is to take PR #2333 back and fix the compiling issue. it contains 2 commits

  1. revert the reverting PR
  2. resolve the compiling issue
    thank you.

@prsunny
Copy link
Collaborator

prsunny commented Jul 27, 2022

@prgeor , can you please sign-off/merge?

keboliu
keboliu previously approved these changes Jul 28, 2022
View reviewed changes
@stephenxs stephenxs requested a review from keboliu July 29, 2022 01:18
keboliu
keboliu previously approved these changes Jul 29, 2022
View reviewed changes
@stephenxs
Copy link
Collaborator Author

stephenxs commented Jul 29, 2022

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jul 29, 2022

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 29, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@keboliu
Copy link
Collaborator

keboliu commented Aug 2, 2022

@prgeor , would you please sign-off/merge?

@prgeor
Copy link
Contributor

prgeor commented Aug 4, 2022

@stephenxs 84a32e2 this commit doesnot seem right. lets discuss.

prgeor
prgeor requested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

84a32e2 why merge from maser?

@stephenxs
Copy link
Collaborator Author

stephenxs commented Aug 4, 2022 •
edited
Loading

84a32e2 why merge from maser?

@prgeor
Merging master back is a common way to resolve conflicts. We do it in this way from time to time

@stephenxs
Revert "Revert "[portsorch] Expose supported FEC modes to STABE_DB an…
7b1b4e8 
…d check whether FEC mode is supported before setting it (sonic-net#2333)" (sonic-net#2396)"

This reverts commit 6565b50.
@stephenxs
Adjust the prototype of setPortFec
0767f27 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the readd-supported-fecs branch from 84a32e2 to 0767f27 Compare August 4, 2022 23:33
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@stephenxs stephenxs requested a review from prgeor August 5, 2022 00:28
@stephenxs
Copy link
Collaborator Author

stephenxs commented Aug 8, 2022

/easycla

@prgeor prgeor merged commit 1e1438e into sonic-net:master Aug 8, 2022
@stephenxs stephenxs deleted the readd-supported-fecs branch August 8, 2022 23:05
@yxieca
Copy link
Contributor

yxieca commented Aug 8, 2022

@stephenxs this PR cannot be cherry picked cleanly to 202205 branch. Please raise separate PR.

@stephenxs stephenxs mentioned this pull request Aug 9, 2022
Merged
7 tasks
yxieca pushed a commit that referenced this pull request Aug 11, 2022
@stephenxs @yxieca
[portsorch] Expose supported FEC modes to STABE_DB and check whether …
87e98eb 
…FEC mode is supported before setting it (#2400)

* Revert "Revert "[portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (#2333)" (#2396)"

This reverts commit 6565b50.

* Adjust the prototype of setPortFec

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@abdosi abdosi mentioned this pull request Aug 25, 2022
Merged
abdosi added a commit that referenced this pull request Aug 30, 2022
@abdosi
Fix the Fec Mode Setting of gbsyncd (#2430)
f52a7b1 
Why I did:

PR: #2400 made change to pass <string> as argument to API setPortFecMode but did not updated the corresponding gbsyncd API call
yxieca pushed a commit that referenced this pull request Sep 1, 2022
@abdosi @yxieca
Fix the Fec Mode Setting of gbsyncd (#2430)
f4a6945 
Why I did:

PR: #2400 made change to pass <string> as argument to API setPortFecMode but did not updated the corresponding gbsyncd API call
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@stephenxs
[portsorch] Expose supported FEC modes to STABE_DB and check whether …
3c0a94c 
…FEC mode is supported before setting it (sonic-net#2400)

* Revert "Revert "[portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (sonic-net#2333)" (sonic-net#2396)"

This reverts commit 6565b50.

* Adjust the prototype of setPortFec

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@abdosi
Fix the Fec Mode Setting of gbsyncd (sonic-net#2430)
70c8861 
Why I did:

PR: sonic-net#2400 made change to pass <string> as argument to API setPortFecMode but did not updated the corresponding gbsyncd API call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prgeor prgeor prgeor approved these changes

@keboliu keboliu keboliu left review comments

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees

No one assigned

Labels

Included in 202205 Branch Request for 202205 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephenxs @prsunny @mssonicbld @keboliu @prgeor @yxieca