Skip to content

Improve pytest speed by grouping 20 tests together.#2390

Merged
prsunny merged 1 commit intosonic-net:masterfrom
pins:improve_py_test
Aug 5, 2022
Merged

Improve pytest speed by grouping 20 tests together.#2390
prsunny merged 1 commit intosonic-net:masterfrom
pins:improve_py_test

Conversation

@mint570
Copy link
Copy Markdown
Contributor

@mint570 mint570 commented Jul 21, 2022

What I did
Group 20 tests together in pytest.

Why I did it
Hope this can improve the speed.

How I verified it
Presubmit test

Details if related

@prsunny prsunny changed the title Improve pytest speend by grouping 10 tests together. Improve pytest speed by grouping 10 tests together. Jul 22, 2022
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Jul 25, 2022

Can we mark this PR ready? or is there more work to be done?

@mint570
Copy link
Copy Markdown
Contributor Author

mint570 commented Jul 26, 2022

Can we mark this PR ready? or is there more work to be done?

It didn't improve much. About 10 min for grouping 10, and about 20 min for grouping 20.
I can try grouping 30.

BTW, the vs test seemed to be broken.

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Jul 26, 2022

Can we mark this PR ready? or is there more work to be done?

It didn't improve much. About 10 min for grouping 10, and about 20 min for grouping 20. I can try grouping 30.

BTW, the vs test seemed to be broken.

I actually see it improved. VS test issue was due to compilation.. its resolved now.

Change-Id: I5a5e9aea034fe371d41ac9ba7e112551df575471
@mint570 mint570 changed the title Improve pytest speed by grouping 10 tests together. Improve pytest speed by grouping 20 tests together. Jul 27, 2022
@mint570 mint570 marked this pull request as ready for review July 27, 2022 17:00
@mint570 mint570 requested a review from prsunny as a code owner July 27, 2022 17:00
@mint570
Copy link
Copy Markdown
Contributor Author

mint570 commented Jul 27, 2022

I don't see much improvement from 20 to 30. I will go with 20 then.

@prsunny this pr is ready after all tests pass.

@mint570
Copy link
Copy Markdown
Contributor Author

mint570 commented Aug 3, 2022

@prsunny
This PR is ready for review. Please take a look.

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Aug 5, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested a review from theasianpianist August 5, 2022 00:01
@prsunny prsunny merged commit 2489ad5 into sonic-net:master Aug 5, 2022
@prsunny prsunny deleted the improve_py_test branch August 5, 2022 16:41
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
*Improve pytest speed by grouping 20 tests together
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
*Improve pytest speed by grouping 20 tests together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants